Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Charts tab now correctly shows the number of plots created #2606

Closed
wants to merge 1 commit into from

Conversation

creilly8
Copy link
Contributor

Description

Closes issue #2603 .

There's no need to prep these specific plots. They all launch directly with no other menu, control, etc. Changed the action to plot_create.

Test by adding the Data Dictionary, Sample View, and/or Data Download to http://localhost:3000/?noheader=1&massnative=hg38-test,TermdbTest. The Charts tab should update accordingly.

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@xzhou82
Copy link
Collaborator

xzhou82 commented Jan 15, 2025

there are other plots that calls prepPlot(). this is the actual cause #2607

@creilly8
Copy link
Contributor Author

there are other plots that calls prepPlot(). this is the actual cause #2607

@xzhou82 , this is the downstream effect of including plot_prep in nav -> https://github.com/stjude/proteinpaint/actions/runs/12795455953. I don't see these same errors in master. If no menu or separate control is launched then there is no need to use plot_prep.

@xzhou82
Copy link
Collaborator

xzhou82 commented Jan 15, 2025

thanks nav CI breaks. testing more

@creilly8
Copy link
Contributor Author

Closing now that the changes in master clarified adding plot_prep does work. See changes in #2607.

@creilly8 creilly8 closed this Jan 15, 2025
@creilly8 creilly8 deleted the issue.2603 branch January 15, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mass nav: launching plots like sampleview and download will not increment chart tab count
2 participants