Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nav should react to plot_prep #2607

Merged
merged 3 commits into from
Jan 15, 2025
Merged

nav should react to plot_prep #2607

merged 3 commits into from
Jan 15, 2025

Conversation

xzhou82
Copy link
Collaborator

@xzhou82 xzhou82 commented Jan 15, 2025

Description

closes #2606

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@xzhou82 xzhou82 requested a review from creilly8 January 15, 2025 19:13
@xzhou82 xzhou82 mentioned this pull request Jan 15, 2025
Closed
3 tasks
creilly8
creilly8 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@creilly8 creilly8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass for me with the changes in master.

@creilly8 creilly8 linked an issue Jan 15, 2025 that may be closed by this pull request
mass nav: launching plots like sampleview and download will not increment chart tab count #2603
Closed
@xzhou82 xzhou82 merged commit abbf662 into master Jan 15, 2025
3 checks passed
@xzhou82 xzhou82 deleted the issue.2603.1 branch January 15, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creilly8 creilly8 creilly8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mass nav: launching plots like sampleview and download will not increment chart tab count
2 participants
@xzhou82 @creilly8