Skip to content

Commit

Permalink
fix: Charts tab now correctly shows the number of plots created
Browse files Browse the repository at this point in the history
  • Loading branch information
creilly8 committed Jan 15, 2025
1 parent 74f9c14 commit e4cd375
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
15 changes: 12 additions & 3 deletions client/mass/charts.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,15 +193,15 @@ function getChartTypeList(self, state) {
////////////////////// PROFILE PLOTS END //////////////////////
{
label: 'Data Dictionary',
clickTo: self.prepPlot,
clickTo: self.createPlot,
chartType: 'dictionary',
config: {
chartType: 'dictionary'
}
},
{
label: 'Sample View',
clickTo: self.prepPlot,
clickTo: self.createPlot,
chartType: 'sampleView',
config: {
chartType: 'sampleView'
Expand Down Expand Up @@ -255,7 +255,7 @@ function getChartTypeList(self, state) {

{
label: 'Data Download',
clickTo: self.prepPlot,
clickTo: self.createPlot,
chartType: 'dataDownload',
config: {
chartType: 'dataDownload',
Expand Down Expand Up @@ -566,6 +566,15 @@ function setRenderers(self) {
const action = { type: 'plot_prep', config: chart.config, id: getId() }
self.app.dispatch(action)
}

/** ALl data selection occurs within the plot (i.e. no external plot controls are needed).
* Launch the plot directly.
* This is a fix for the charts tab not correctly displaying the number of plots.
*/
self.createPlot = function (chart) {
const action = { type: 'plot_create', config: chart.config, id: getId() }
self.app.dispatch(action)
}
}

// to assign chart ID to distinguish between chart instances
Expand Down
3 changes: 2 additions & 1 deletion release.txt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@

Fixes:
- Charts tab now correctly shows the number of plots created

0 comments on commit e4cd375

Please sign in to comment.