Initial implementation of purchase collection. #308

Joaoaraujo97 · 2024-06-19T18:34:18Z

Realizei a integração do RevenueCat com a aplicação.

Foram criados novos Gateway, Repository e Service para a compra do deck pago.
Estamos utilizando o RevenueCat como backend da nossa aplicação para verificar se o deck foi comprado ou não, ainda estamos em testes.
Caso não haja internet é mostrado somente os decks que são gratuitos ou que já são comprados.
Os decks pagos são setados no JSON como isPremium, caso sejam isPremium eles são classificados como !isVisible até que sejam comprados e tornados isVisible e sendo liberados juntamente com os decks restantes.
Está pendente ainda a inclusão e configuração da PlayStoreID.
Ainda faltam serem inclusos os arquivos StoreKitConfig.storekit e StoreKitTestCertificate.cer.

lucasbiancogs

Faltam ainda algumas decisões sobre como os serviços e repositórios devem se comunicar e qual a responsabilidade de cada um, acho interessante falarmos sobre isso numa próxima reunião.

lucasbiancogs · 2024-07-01T19:59:14Z

android/app/src/debug/AndroidManifest.xml

Isso é realmente necessário? Se sim, deveria estar nos outros manifestos também.

Verificar principalmente o exported

lucasbiancogs · 2024-07-01T20:00:23Z

assets/collections/0_chatGPT_premium.json

Esse é um exemplo, melhor não subir ele junto, manter para testes, ou fazer um deck real pra já inserirmos

Acho q renomeia esse cara pra mock, pra depois nós tirarmos ele

lucasbiancogs · 2024-07-01T20:05:53Z

ios/Runner.xcodeproj/project.pbxproj

Isso foi gerado por ti para fazer o revenueCat funcionar ou foi automático pelo XCode?

lucasbiancogs · 2024-07-01T20:15:12Z

lib/application/constants/exception_strings.dart

@@ -14,6 +14,9 @@ String descriptionForException(BaseException exception) {

    case ExceptionType.failedToOpenUrl:
      return 'Algo deu errado ao tentar abrir o link!';
+
+    case ExceptionType.failedPurchase:


Suggested change

case ExceptionType.failedPurchase:

case ExceptionType.failedToPurchase:

lucasbiancogs · 2024-07-01T20:17:46Z

lib/application/constants/strings.dart

@@ -30,6 +30,10 @@ const collectionsSectionHeaderSeeAll = 'Ver todos';

 const collectionsStartNow = 'Começar Agora';

+const collectionPurchaseDeck = r'Comprar deck - R$ 0.99';


Isso deveria ser variável com o valor.

Suggested change

const collectionPurchaseDeck = r'Comprar deck - R$ 0.99';

String collectionPurchaseDeck(double price) => r'Comprar deck - R$ $(price.toStringAsFixed(2))';

lucasbiancogs · 2024-07-03T18:09:41Z

lib/domain/services/collection_purchase_services.dart

+  Future<bool> isVisible({required String id}) async {
+    final collection = await collectionRepo.getCollection(id: id);
+
+    if (collection.isPremium) {
+      final isAvailable = await collectionPurchaseRepo.isAvailable();
+      final isPurchased = await collectionPurchaseRepo.getPurchasesInfo();
+
+      if (isAvailable.contains(collection.appStoreId) || isAvailable.contains(collection.playStoreId)) {
+        return !isPurchased.contains(collection.appStoreId) || !isPurchased.contains(collection.playStoreId);
+      }
+    }
+    return collection.isPremium;


De novo, o isPremium é uma coisa, o isVisible é outra. N deveriam estar associados.

lucasbiancogs · 2024-07-03T18:12:39Z

lib/domain/services/collection_purchase_services.dart

+  Future<void> _purchaseInAppCollection(Collection collection) async {
+    switch (env.platform) {
+      case SupportedPlatform.ios:
+        await collectionPurchaseRepo.purchaseInApp(storeId: collection.appStoreId);
+        break;
+      case SupportedPlatform.android:
+        await collectionPurchaseRepo.purchaseInApp(storeId: collection.playStoreId);
+        break;
+    }
+  }


NIP - Isso está ok, mas ficaria mais claro se tu só retornasse a string e no método tu chamasse o repositório, exemplo:

Suggested change

Future<void> _purchaseInAppCollection(Collection collection) async {

switch (env.platform) {

case SupportedPlatform.ios:

await collectionPurchaseRepo.purchaseInApp(storeId: collection.appStoreId);

break;

case SupportedPlatform.android:

await collectionPurchaseRepo.purchaseInApp(storeId: collection.playStoreId);

break;

}

}

// Dentro do repositório

await collectionPurchaseRepo.purchaseInApp(_collectionStore(collection));

....

String _collectionStore(Collection collection) {

switch (env.platform) {

case SupportedPlatform.ios:

return collection.appStoreId;

case SupportedPlatform.android:

return collection.playStoreId;

}

}

lucasbiancogs · 2024-07-03T18:15:22Z

lib/domain/services/collection_services.dart

-      },
-    );
+    try {
+      final isAvailbleList = await collectionPurchaseRepo.isAvailable();


É melhor expor isso no serviço CollectionPurchaseServices, assim esse serviço nem precisa saber do collectionPurchaseRepo, já q tu quer usar esse serviço aqui. Melhor era na verdade o collection services nem saber nada sobre compra. Pra isso tu teria q angariar essas informações na vm e nela montar o card baseado no serviço de CollecionServices e de CollectionPurchaseServices.

lucasbiancogs · 2024-07-03T18:20:36Z

test/data/serializers/collection_memos_serializer_test.dart

@@ -15,13 +15,15 @@ void main() {
    description: 'This collection represents a collection.',
    category: 'Category',
    tags: const ['Tag 1', 'Tag 2'],
+    isPremium: false,
+    appStoreId: 'appStoreId',


E o playStoreId?

lucasbiancogs · 2024-07-03T18:20:48Z

test/fixtures/collection.json

+    "Tag 2"
+  ],
+  "isPremium": false,
+  "appStoreId": "appStoreId",


E o playStoreId?

lucasbiancogs · 2024-07-05T19:01:10Z

lib/application/widgets/theme/collection_card.dart

@@ -35,6 +37,9 @@ class CollectionCard extends ConsumerWidget {
  /// List of tags associated with this collection.
  final List<String> tags;

+  ///


Missing doc

Ainda falta o doc

lucasbiancogs · 2024-07-05T19:07:29Z

lib/data/serializers/collection_serializer.dart

@@ -41,6 +44,12 @@ class CollectionSerializer implements Serializer<Collection, Map<String, dynamic
    final rawContributors = List<Map<String, dynamic>>.from(json[CollectionKeys.contributors] as List);
    final contributors = rawContributors.map(contributorSerializer.from).toList();

+    final isPremium = json[CollectionKeys.isPremium] as bool;


Aqui teremos que ou fazer uma migração ou colocar como default false

lucasbiancogs · 2024-07-09T04:58:38Z

assets/collections/0_chatGPT_premium.json

Acho q renomeia esse cara pra mock, pra depois nós tirarmos ele

lucasbiancogs · 2024-07-09T04:58:57Z

assets/collections/0_chatGPT_premium.json

+    "isPremium": true,
+    "productInfo": {
+        "price": 0.99,
+        "productId": "com.olmps.memo_099_in_app_purchase_deck"


Q tal só id?

lucasbiancogs · 2024-07-09T04:59:37Z

assets/collections/bdd_fundamentos_01.json

+  "productInfo": {
+    "price": null,
+    "productId": null


Idealmente eu nem colocaria o productInfo se n for premium

lucasbiancogs · 2024-07-09T05:12:56Z

lib/data/repositories/purchase_repository.dart

+  /// Updates the collection with the [id] to be premium or not.
+  Future<void> updatePurchase({required String purchaseId});
+
+  Future<List<String>> getPurchaseProducts();


Suggested change

Future<List<String>> getPurchaseProducts();

Future<List<String>> getPurchasedProducts();

lucasbiancogs · 2024-07-09T05:13:52Z

lib/data/repositories/purchase_repository.dart

+  /// Receives purchase information made by the user.
+  Future<List<String>> getPurchasesInfo();


Ser mais específico na documentação e no nome. Q info q é puxada? É o id do produto?

lucasbiancogs · 2024-07-09T05:14:20Z

lib/data/repositories/purchase_repository.dart

+  /// Updates the collection with the [id] to be premium or not.
+  Future<void> updatePurchase({required String purchaseId});
+
+  Future<List<String>> getPurchaseProducts();


Aqui tbm pode ser mais específico no nome e também falta a documentação

lucasbiancogs · 2024-07-09T05:15:50Z

lib/domain/services/collection_purchase_services.dart

+
+  Future<void> _updatePurchaseCollection({required String id}) async {
+    final collection = await collectionRepo.getCollection(id: id);
+    final isPurchased = await purchaseRepo.getPurchasesInfo();


Esse uso do verbo no isPurchased faz muita referencia a um booleano, aqui o ideal seria outro nome como, purchasesIds ou remotePurchases.

lucasbiancogs · 2024-07-09T05:17:47Z

lib/application/view-models/app_vm.dart

+    await Future.wait<dynamic>([
+      collectionPurchaseServices.updatePurchasesIfNeeded(),
+    ]);
+


Pq não só colocar no Future.wait acima?

lucasbiancogs

Colocar no readme abaixo dos sponsors

Revenue

We are currently exploring new approaches to generate revenue with the app. The implementation of the paid deck feature can be found in the code, along with an example of a paid deck. Other decks will not be visible on GitHub to ensure we can properly validate this revenue model.

lucasbiancogs · 2024-07-10T19:33:32Z

lib/domain/services/collection_purchase_services.dart

    await _updatePurchaseCollection(id: id);
  }

  Future<void> _updatePurchaseCollection({required String id}) async {
    final collection = await collectionRepo.getCollection(id: id);
-    final isPurchased = await purchaseRepo.getPurchasesInfo();
+    final purchasesId = await purchaseRepo.getUserPurchases();


NIP

Suggested change

final purchasesId = await purchaseRepo.getUserPurchases();

final purchasesIds = await purchaseRepo.getUserPurchases();

lucasbiancogs · 2024-07-10T19:35:51Z

test/data/serializers/collection_serializer_test.dart

-      productInfo: ProductInfo(price: 0.0, id: ''),
+      // productInfo: ProductInfo(price: 0.0, id: ''),


Fazer o teste da serialização do productInfo

lucasbiancogs

LGTM 🚀

Initial implementation of purchase collection.

9e98536

Joaoaraujo97 requested a review from lucasbiancogs June 19, 2024 18:34

Joaoaraujo97 added 3 commits June 26, 2024 12:11

Fixes for new purchasing approach.

37b64a1

Theme adjustments.

31ca12d

Adjustments and inclusion of the playStoreId.

0face03

lucasbiancogs changed the base branch from main to dev July 1, 2024 19:47

lucasbiancogs requested changes Jul 3, 2024

View reviewed changes

Joaoaraujo97 added 3 commits July 5, 2024 14:54

Fixes on purchase collections.

09bb6d7

Minimal fix on manifest.

9b137c9

More fixes on Purchase Collections.

dd26b55

Joaoaraujo97 requested a review from lucasbiancogs July 8, 2024 21:57

lucasbiancogs requested changes Jul 9, 2024

View reviewed changes

Some more fixes in collection purchases.

49abade

lucasbiancogs requested changes Jul 10, 2024

View reviewed changes

Inclusion of the README and the productInfo serialization test.

f3597bc

Joaoaraujo97 requested a review from lucasbiancogs July 11, 2024 18:57

lucasbiancogs approved these changes Jul 12, 2024

View reviewed changes

Joaoaraujo97 and others added 3 commits July 15, 2024 14:32

Fix in collection details.

81ac7a9

Implements new collection purchase view model

051e7bf

Sorts collections by their premium status

2f2c0b5

jonata97 merged commit d6c8260 into dev Jul 29, 2024

jonata97 deleted the purchase-collections branch July 29, 2024 12:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial implementation of purchase collection. #308

Initial implementation of purchase collection. #308

Joaoaraujo97 commented Jun 19, 2024

lucasbiancogs left a comment

lucasbiancogs Jul 1, 2024

lucasbiancogs Jul 1, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 1, 2024

lucasbiancogs Jul 1, 2024

lucasbiancogs Jul 1, 2024

lucasbiancogs Jul 3, 2024

lucasbiancogs Jul 3, 2024

lucasbiancogs Jul 3, 2024

lucasbiancogs Jul 3, 2024

lucasbiancogs Jul 3, 2024

lucasbiancogs Jul 5, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 5, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs Jul 9, 2024

lucasbiancogs left a comment

lucasbiancogs Jul 10, 2024

lucasbiancogs Jul 10, 2024

lucasbiancogs left a comment

	case ExceptionType.failedPurchase:
	case ExceptionType.failedToPurchase:

		@@ -30,6 +30,10 @@ const collectionsSectionHeaderSeeAll = 'Ver todos';

		const collectionsStartNow = 'Começar Agora';

		const collectionPurchaseDeck = r'Comprar deck - R$ 0.99';

	const collectionPurchaseDeck = r'Comprar deck - R$ 0.99';
	String collectionPurchaseDeck(double price) => r'Comprar deck - R$ $(price.toStringAsFixed(2))';

	Future<List<String>> getPurchaseProducts();
	Future<List<String>> getPurchasedProducts();

		/// Receives purchase information made by the user.
		Future<List<String>> getPurchasesInfo();

	final purchasesId = await purchaseRepo.getUserPurchases();
	final purchasesIds = await purchaseRepo.getUserPurchases();

		productInfo: ProductInfo(price: 0.0, id: ''),
		// productInfo: ProductInfo(price: 0.0, id: ''),

Initial implementation of purchase collection. #308

Initial implementation of purchase collection. #308

Conversation

Joaoaraujo97 commented Jun 19, 2024

lucasbiancogs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasbiancogs left a comment

Choose a reason for hiding this comment

Revenue

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lucasbiancogs left a comment

Choose a reason for hiding this comment