docs: add headinglevel to Nunjucks macro options #1052
Conversation
docs/_includes/arguments/timeline.md
Outdated
| @@ -4,6 +4,7 @@ | |||
| | ---------- | ------ | -------- | --------------------------------------------------------------------------------- | | |||
| | classes | string | No | Classes to add to the timeline's container. | | |||
| | attributes | object | No | HTML attributes (for example data attributes) to add to the timeline's container. | | |||
| | headingLevel | object | No | Defaults to 2 (`<h2>`). | | |||
There was a problem hiding this comment.
This works, in that the code renders the new line correctly but if I was being nitpicky I'd say we should add extra spaces on lines 3-6 so that the vertical lines of the table align with the new line for readability.
There was a problem hiding this comment.
headingLevel should be a type of numeric not object
docs/_includes/arguments/timeline.md
Outdated
| @@ -4,6 +4,7 @@ | |||
| | ---------- | ------ | -------- | --------------------------------------------------------------------------------- | | |||
| | classes | string | No | Classes to add to the timeline's container. | | |||
| | attributes | object | No | HTML attributes (for example data attributes) to add to the timeline's container. | | |||
| | headingLevel | object | No | Defaults to 2 (`<h2>`). | | |||
There was a problem hiding this comment.
headingLevel should be a type of numeric not object
|
@chrispymm Sorry, don't know why I did that. Have changed and pushed. |
docs/_includes/arguments/timeline.md
Outdated
| | ---------- | ------ | -------- | --------------------------------------------------------------------------------- | | ||
| | classes | string | No | Classes to add to the timeline's container. | | ||
| | attributes | object | No | HTML attributes (for example data attributes) to add to the timeline's container. | | ||
| | headingLevel | numeric | No | Defaults to 2 (`<h2>`). | |
There was a problem hiding this comment.
Sorry, I obviously didn't read this properly last night. I thought we were usding the same description for headingLevel as from side navigation? which is:
A number for the heading level. Defaults to 4 (
<h4>)
If you decided to change it that's fine, just wanted to check.
|
🎉 This PR is included in version 3.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.