Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add headinglevel to Nunjucks macro options #1052

Merged
merged 4 commits into from
Jan 7, 2025
Merged

docs: add headinglevel to Nunjucks macro options #1052

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e568856
docs: add headinglevel to Nunjucks macro options
helennickols Jan 6, 2025
a005218
Update timeline.md
helennickols Jan 6, 2025
25032b3
docs: add headinglevel to numeric type
helennickols Jan 6, 2025
e76d48a
docs: content tweak
helennickols Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/_includes/arguments/timeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
| ---------- | ------ | -------- | --------------------------------------------------------------------------------- |
| classes | string | No | Classes to add to the timeline's container. |
| attributes | object | No | HTML attributes (for example data attributes) to add to the timeline's container. |
| headingLevel | object | No | Defaults to 2 (`<h2>`). |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, in that the code renders the new line correctly but if I was being nitpicky I'd say we should add extra spaces on lines 3-6 so that the vertical lines of the table align with the new line for readability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

headingLevel should be a type of numeric not object


### Items

Expand Down
Loading