Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document heading level config options for Timeline component #996

Closed
robertjmccarthy opened this issue Dec 11, 2024 · 2 comments
Closed
Assignees

Comments

@robertjmccarthy
Copy link
Contributor

robertjmccarthy commented Dec 11, 2024

What

Update Timeline component nunjuck macro options to reflect configurable heading levels.

Why

@aliuk2012 spotted that the Timeline component has a configurable heading option which is not documented within the components nunjuck macro options.

Link to Slack message on #moj-design-system-support Slack channel: https://mojdt.slack.com/archives/CH5RUSB27/p1733904532246179

Who needs to be involved

  • Content Designer (leading)
  • Developer (supporting)

Done

When the nunjuck macro option is updated to reflect the configurable heading level, and @aliuk2012 is notified of the update.

@helennickols
Copy link
Contributor

Chris and I have agreed the following. This is the exact styling of capitals etc:
Name - headingLevel
Type - numeric
Required - No
Description - A number for the heading level. Defaults to 2 (

).

This follows the style in the Side nav (but we have added a full stop after the round brackets).

I'll do a PR now.

@helennickols
Copy link
Contributor

@chrispymm PR please #1052

@helennickols helennickols moved this from In Progress to Done in MoJ Design System: Team planning Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants