[exprtk] Add versions 0.0.2 #42996

ArashPartow · 2024-12-30T03:28:16Z

Changes comply with the maintainer guide.
SHA512s are updated for each updated download.
The "supports" clause reflects platforms that may be fixed by this new version.
The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

Closes: #42173, #40270, #33571, #30058, #29955, #29801, #29775, #29665, #38756

@PhoebeHui / @jimwang118 / @JonLiu1993 / @LilyWangLL

LilyWangLL · 2024-12-30T07:19:01Z

The pipeline errors will be fixed by PR #42912.

ArashPartow · 2024-12-30T07:28:19Z

@LilyWangLL thanks for the update on the pipeline issue.

Please feel free to merge this PR, once #42912 and the current PR's pipeline goes all green 🟢

ArashPartow

This PR will now only contain tag 0.0.2 instead of both 0.0.2 and 0.0.3

LilyWangLL · 2024-12-30T08:25:19Z

@LilyWangLL can you please revert the change you made specifically: 8770ed9

That version is intentionally there it is tag 0.0.2.

On a side note: Not sure why Github will not allowed me to request a change on my own PR .

In fact, version 2023-01-01 does not exist in vcpkg. This PR directly upgraded from version 2022-01-01 to version 2024-01-01.

LilyWangLL · 2024-12-30T08:47:22Z

The commit for version 2023-01-01 is just a historical submission in this PR. The final data merged in the PR reflects the final changes, just from version 2022-01-01 to version 2024-01-01.

After this PR is merged, users will only be able to install versions 2022-01-01 and 2024-01-01 in vcpkg, and not version 2023-01-01. The data in this JSON file needs to correspond to the changes shown in the image below and should not include any additional modifications.

LilyWangLL · 2024-12-30T08:56:58Z

If you want both versions 2023-01-01 and 2024-01-01 to be installable, you need to submit separate PRs for each version. After version 2023-01-01 is merged, then merge version 2024-01-01.

ArashPartow · 2024-12-30T09:01:14Z

@LilyWangLL ok, I'll convert this PR to 2023 and then create another one once this has been merged for 2024, are you ok with me proceeding?

LilyWangLL · 2024-12-30T09:06:43Z

@LilyWangLL ok, I'll convert this PR to 2023 and then create another one once this has been merged for 2024, are you ok with me proceeding?

That's great!

ArashPartow · 2024-12-30T09:57:34Z

@LilyWangLL updated the PR to only include 0.0.2

Please merge the PR once the pipeline issues have been resolved.

dg0yt · 2024-12-30T12:18:23Z

ports/exprtk/vcpkg.json

@@ -1,7 +1,6 @@
 {
  "name": "exprtk",
-  "version-date": "2022-01-01",
-  "port-version": 2,
+  "version-date": "2023-01-01",


This port should finally decide which version scheme to use. The subject says 0.0.2, and there is also a tag for it.

@ArashPartow we should be using the version scheme that upstream uses. In this case, it appears there's a tag for 0.0.3 or use the tag that corresponds with this version, 0.0.2?

ports/exprtk/copyright

dg0yt · 2024-12-30T12:20:58Z

ports/exprtk/portfile.cmake

+    REF F46BFFCD6966D38A09023FB37BA9335214C9B959
+    SHA512 5D4F1CC49E035860D9B2410A9B48E1ADF8784C6301A31B2C7462C2DBFA64CA6763A832354E57414919DF7B7D23975F5F7759D0984BECAF25B39FB0AEDE6B716F


Nitpick: In vcpkg ports, we usually see lower case for these values.

Is there a formal definition anywhere regarding this? I checked other ports and it seems to be a mixed bag. It will be uppercase for this port.

There is more like a dominant inflow than a mixed bag.
git uses lower case.
sha512sum produces lower case (on linux).
cmake -E sha512sum produces lower case.
vcpkg hash produces lower case. (IIRC it was deliberately change to do that. Does this count as a formal definition?)

ArashPartow · 2024-12-31T16:51:54Z

@LilyWangLL can you please merge this PR, as I need to do the next one.

dg0yt · 2025-01-01T11:16:57Z

Not resolved: Use lower-case SHA512 and git ref SHA, #42996 (comment).

Still confusing: Versioning.

ArashPartow · 2025-01-01T17:53:45Z

Not resolved: Use lower-case SHA512 and git ref SHA, #42996 (comment).

@dg0yt I requested you provide a guideline that requires this. Please also note you have since the start of 2023 getting in the way of ExprTk being updated, with nitpicks etc. Can you please refrain from this PR unless you have serious and legitimate concerns.

ports/edlib/portfile.cmake:    SHA512 720C732C76D0D9ABE28ADCE9972B355864571A2E6CBD2C72C3B4A92E045A99E3A688153865586F7E8B6C90433E2EB1BB024AD0A6E9D4EB4B4D401A160D3F13CE
ports/srell/portfile.cmake:     SHA512 5F2762A98E1B68C3A4FA79051AE2CBEFD23CEDF1CE833FA1EB812D3F1112734018AF36AA9D9A50E2DC40C87A7FAAF46AF0B8F4161481994DC5E19F44301E867D
ports/sparsehash/portfile.cmake:    SHA512 40C007BC5814DD5F2BDACD5EC884BC5424F7126F182D4C7B34371F88B674456FC193B947FDD283DBD0C7EB044D8F06BAF8CAEC6C93E73B1B587282B9026EA877
ports/indicators/portfile.cmake:    SHA512 59FB17E93C886CEC2418E93E221FEBD2BF3160691B3473363417F8F8FA3D50D42D1DE0E55D62598EBA800B13C1D5AB1422D0A2C867246006B61340BA32D99232
ports/fakeit/portfile.cmake:    SHA512 CA9932DF909D6C7F75AB775B6AC9695C80F1DC4A58599C789EEA279A05183E9568BB80B63EBDA5EF77EDD54D766977AB7C5BCD565FB45A61B56CB8D43E49007B
ports/qcoro/portfile.cmake:    SHA512 BDE5C5CD9F3C038E6B5EC5A6ADAE5AE2218EDD9DF350E75FC5D8DB31D9339484E92CC88FDC37FA0539E0CDF1F53731418EBFA73B94564E993D7B02168988771B
ports/nmslib/portfile.cmake:    SHA512 62BBB965EA4BF1D416ED78231B1BA4B41C0F46327D7BE16D1F98095DB63EF0E0D893B70040009711BC9C68555B1B8C4038F5032ABD66B759E955E2CBB0553EC3
ports/greatest/portfile.cmake:    SHA512 836392A7C9C56C6A5658FD18B4BBB146304B1997DFD9CB59F2A83C18A5EC140C8DDE64A2C0CF9A169C426B9E586D37E2ED7D7FB792402DBB4149CC424EC2DB2E
ports/zeroc-ice/prepare_for_build.cmake:            SHA512 E65620F3B667A48B28EC770443296BB0B8058168197DB3AE877A36531FFC6CE7E9289C7FE37DFAD751877FBDBA03C55E37122931BBF001EA6F1906DFEEBACFCB
ports/snap7/portfile.cmake:    SHA512 84F4E1AD15BFEC201F9EB1EC90A28F37DFC848E370DB5CEA22EF4946F41FF6CC514581D29D592B57EE6D4C77F4AABB4B2BBA1E3637043161821BA2FFAE7F2DD6
ports/clue/portfile.cmake:    SHA512 A142EDD57753DA36687803332E81BD9D4413203F69F0055466219437C3385C593384DA2A3C6BC67B39EC7ED0C36854354F34C2AA2D4CE4F1D2B912546F4F46B2
ports/distorm/portfile.cmake:    SHA512 8AAD0C51E8D9DFAEAA069A3D4FADE4BDF87CCE464C85898B6B4888FA51A9BB6EC1221FAF32ACF59EBD047CCEB9A535B2FF93D196FD14FA834D8ECE5685417A55
ports/rpclib/portfile.cmake:    SHA512 9C65AE5D000CD66E39498667DC826A4E8A2C28EB4138CFFE3AA09D5DDC22575551B9FA6CE9D951343213B9583F947899CB18B58130AEAEE36DAB5881EA496272
ports/tl-optional/portfile.cmake:    SHA512 3911F397440D4383721B92DE614DE1BEF5DB5C88371FA35F008B92F673F1E1EBF46E98FCFF4CD2D71E558C89537B9128AD549777197FD0390ED18A5BDFC5D6E0
ports/yas/portfile.cmake:       SHA512 1101BBE0B11FF8FA3B40B1E3030E5E93125FEDC85A90532466C9E6E0708B1C4C38821C86FCAFE153717B66B7107FCB29D0E13E87E68BF2217948A7014FC3BAC0
ports/minisat-master-keying/portfile.cmake:    SHA512 48E7AC1C97EA58070EAB9310F977404295E881B1403D527A33E059A0BB5A16CAA9AF2FA9E5230AD7E53E008B83077E300B3BAEEB0C220BE4E52B6B85887A05E1
ports/strong-type/portfile.cmake:    SHA512 "67F6F0AC34703206A5F45B492CB52ACAF87189D137B3CA5F9A0BB3708FE91FF4FBA61B6BFD9CDC8D2494D112F7964C8BE366F2ECECEF3B8B5B7CC1F318EFAFDD"
ports/quill/portfile.cmake:    SHA512 75FF87FD0A51F9A35C748421589411B21449CEAFF930843A8A1142B0BA6B3C20821E29FA2CE7F746C4304F652D576DFB306CCA1627849911CA4B1D7ADD05332A
ports/bond/portfile.cmake:        SHA512 4CD92F0665E36CB718311A237DF80B8CD93BFE33971F6460B88A1B74E9E2237D6AEA146766D6AE92674E2DDBBB3245CEBB199FF5BA82163FE69781340E0479AE
ports/easyhook/portfile.cmake:    SHA512 D0CA5B64E77F6281B2DD7EE0DC492A9B07DDB60A9F514037938CC3E3FFA5DD57C95CB630E18C02C984A89070839E4188044896D4EE57A21E43E6EA3A4918255A
ports/libassert/portfile.cmake:    SHA512 848D961CA884734FDB9C9440098E40EC9A4A7586C7A3D223D94A57513D904FB582B032A9F179A0D7C7D8AF76CF178CA215233642F651CF51A27200200DD7052A

Just a short sampling, but have you been involved in any of these?

Still confusing: Versioning.

when I originally created the port vcpkg for this library, I followed another port's scheme, because the library doesn't use semver. I've added semver recently to the GH repo to make it easier for people that use package managers. This was accepted at the time. So I'm not sure what is the best path going forward that wont break backwards compatibility. In short if you have a complete and viable solution please let me know. Otherwise you are always free to make your own PR once these have been merged and take over this port.

ArashPartow · 2025-01-01T17:55:36Z

@Cheney-W / @Mengna-Li / @PhoebeHui / @jimwang118 / @JonLiu1993 / @LilyWangLL Can any of you please merge this PR. Been trying to get it merged since early 2023

JavierMatosD

See comments

JavierMatosD · 2025-01-03T17:06:56Z

ports/exprtk/copyright

@@ -1,8 +1,24 @@
-Copyright 1999-2022 Arash Partow


I see that upstream has a license file. Please just install that copyright file rather than checking it in here.

JavierMatosD · 2025-01-03T17:10:08Z

ports/exprtk/vcpkg.json

@@ -1,7 +1,6 @@
 {
  "name": "exprtk",
-  "version-date": "2022-01-01",
-  "port-version": 2,
+  "version-date": "2023-01-01",


@ArashPartow we should be using the version scheme that upstream uses. In this case, it appears there's a tag for 0.0.3 or use the tag that corresponds with this version, 0.0.2?

[exprtk] Add version 0.0.2 2023-01-01

0ec126a

ArashPartow marked this pull request as ready for review December 30, 2024 05:50

jimwang118 assigned LilyWangLL Dec 30, 2024

LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Dec 30, 2024

LilyWangLL added the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 30, 2024

LilyWangLL approved these changes Dec 30, 2024

View reviewed changes

ArashPartow commented Dec 30, 2024

View reviewed changes

ArashPartow force-pushed the arashpartow/update_exprtk_0.0.3 branch from 24fc06d to 6367623 Compare December 30, 2024 08:27

LilyWangLL self-requested a review December 30, 2024 08:50

ArashPartow force-pushed the arashpartow/update_exprtk_0.0.3 branch from 6367623 to 0ec126a Compare December 30, 2024 09:56

ArashPartow changed the title ~~[exprtk] Add versions 0.0.2 and 0.0.3~~ [exprtk] Add versions 0.0.2 Dec 30, 2024

LilyWangLL approved these changes Dec 30, 2024

View reviewed changes

dg0yt reviewed Dec 30, 2024

View reviewed changes

ArashPartow mentioned this pull request Dec 30, 2024

[g2o] Add feature spdlog #42912

Merged

7 tasks

ArashPartow closed this Dec 31, 2024

ArashPartow reopened this Dec 31, 2024

ArashPartow closed this Dec 31, 2024

ArashPartow reopened this Dec 31, 2024

LilyWangLL removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 31, 2024

ArashPartow mentioned this pull request Dec 31, 2024

[exprtk] Add version 0.0.3 2024-01-01 #43036

Draft

4 tasks

LilyWangLL approved these changes Jan 2, 2025

View reviewed changes

LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 2, 2025

JavierMatosD requested changes Jan 3, 2025

View reviewed changes

JavierMatosD marked this pull request as draft January 3, 2025 17:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[exprtk] Add versions 0.0.2 #42996

[exprtk] Add versions 0.0.2 #42996

ArashPartow commented Dec 30, 2024 •

edited

Loading

LilyWangLL commented Dec 30, 2024

ArashPartow commented Dec 30, 2024

ArashPartow left a comment •

edited

Loading

LilyWangLL commented Dec 30, 2024

LilyWangLL commented Dec 30, 2024

LilyWangLL commented Dec 30, 2024

ArashPartow commented Dec 30, 2024

LilyWangLL commented Dec 30, 2024

ArashPartow commented Dec 30, 2024 •

edited

Loading

dg0yt Dec 30, 2024

JavierMatosD Jan 3, 2025 •

edited

Loading

dg0yt Dec 30, 2024

ArashPartow Dec 30, 2024

dg0yt Dec 30, 2024

ArashPartow commented Dec 31, 2024

dg0yt commented Jan 1, 2025

ArashPartow commented Jan 1, 2025

ArashPartow commented Jan 1, 2025

JavierMatosD left a comment •

edited

Loading

JavierMatosD Jan 3, 2025

JavierMatosD Jan 3, 2025 •

edited

Loading

		REF F46BFFCD6966D38A09023FB37BA9335214C9B959
		SHA512 5D4F1CC49E035860D9B2410A9B48E1ADF8784C6301A31B2C7462C2DBFA64CA6763A832354E57414919DF7B7D23975F5F7759D0984BECAF25B39FB0AEDE6B716F

[exprtk] Add versions 0.0.2 #42996

Are you sure you want to change the base?

[exprtk] Add versions 0.0.2 #42996

Conversation

ArashPartow commented Dec 30, 2024 • edited Loading

LilyWangLL commented Dec 30, 2024

ArashPartow commented Dec 30, 2024

ArashPartow left a comment • edited Loading

Choose a reason for hiding this comment

LilyWangLL commented Dec 30, 2024

LilyWangLL commented Dec 30, 2024

LilyWangLL commented Dec 30, 2024

ArashPartow commented Dec 30, 2024

LilyWangLL commented Dec 30, 2024

ArashPartow commented Dec 30, 2024 • edited Loading

dg0yt Dec 30, 2024

Choose a reason for hiding this comment

JavierMatosD Jan 3, 2025 • edited Loading

Choose a reason for hiding this comment

dg0yt Dec 30, 2024

Choose a reason for hiding this comment

ArashPartow Dec 30, 2024

Choose a reason for hiding this comment

dg0yt Dec 30, 2024

Choose a reason for hiding this comment

ArashPartow commented Dec 31, 2024

dg0yt commented Jan 1, 2025

ArashPartow commented Jan 1, 2025

ArashPartow commented Jan 1, 2025

JavierMatosD left a comment • edited Loading

Choose a reason for hiding this comment

JavierMatosD Jan 3, 2025

Choose a reason for hiding this comment

JavierMatosD Jan 3, 2025 • edited Loading

Choose a reason for hiding this comment

ArashPartow commented Dec 30, 2024 •

edited

Loading

ArashPartow left a comment •

edited

Loading

ArashPartow commented Dec 30, 2024 •

edited

Loading

JavierMatosD Jan 3, 2025 •

edited

Loading

JavierMatosD left a comment •

edited

Loading

JavierMatosD Jan 3, 2025 •

edited

Loading