Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exprtk] Add versions 0.0.2 #42996

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −13
Draft

[exprtk] Add versions 0.0.2 #42996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions ports/exprtk/copyright
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,24 @@
Copyright 1999-2022 Arash Partow
MIT License

Copyright (c) 1999-2024 Arash Partow

https://www.partow.net/programming/exprtk/index.html

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
10 changes: 5 additions & 5 deletions ports/exprtk/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO ArashPartow/exprtk
REF 806C519C91FD08BA4FA19380DBF3F6E42DE9E2D1
SHA512 A323CCAF161FD0087FD8208D1B24C2A3FD422F8875E29B22AE70E6DD2F10F396F6BF1AD36D3FFDC10D32314AE8F83749974301A349BE0F27733292BCF5193640
HEAD_REF master
REF F46BFFCD6966D38A09023FB37BA9335214C9B959
SHA512 5D4F1CC49E035860D9B2410A9B48E1ADF8784C6301A31B2C7462C2DBFA64CA6763A832354E57414919DF7B7D23975F5F7759D0984BECAF25B39FB0AEDE6B716F
Comment on lines +4 to +5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: In vcpkg ports, we usually see lower case for these values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a formal definition anywhere regarding this? I checked other ports and it seems to be a mixed bag. It will be uppercase for this port.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is more like a dominant inflow than a mixed bag.
git uses lower case.
sha512sum produces lower case (on linux).
cmake -E sha512sum produces lower case.
vcpkg hash produces lower case. (IIRC it was deliberately change to do that. Does this count as a formal definition?)

HEAD_REF release
)

file(COPY ${SOURCE_PATH}/exprtk.hpp DESTINATION ${CURRENT_PACKAGES_DIR}/include)
file(COPY ${CMAKE_CURRENT_LIST_DIR}/copyright DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT})
file(COPY ${SOURCE_PATH}/exprtk.hpp DESTINATION "${CURRENT_PACKAGES_DIR}/include")
vcpkg_install_copyright(FILE_LIST "${CMAKE_CURRENT_LIST_DIR}/copyright")
3 changes: 1 addition & 2 deletions ports/exprtk/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "exprtk",
"version-date": "2022-01-01",
"port-version": 2,
"version-date": "2023-01-01",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This port should finally decide which version scheme to use. The subject says 0.0.2, and there is also a tag for it.

Copy link
Contributor

@JavierMatosD JavierMatosD Jan 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArashPartow we should be using the version scheme that upstream uses. In this case, it appears there's a tag for 0.0.3 or use the tag that corresponds with this version, 0.0.2?

"description": "Simple to use, easy to integrate and extremely efficient run-time C++ mathematical expression parser and evaluation engine.",
"homepage": "https://www.partow.net/programming/exprtk/index.html",
"license": "MIT"
Expand Down
4 changes: 2 additions & 2 deletions versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2637,8 +2637,8 @@
"port-version": 0
},
"exprtk": {
"baseline": "2022-01-01",
"port-version": 2
"baseline": "2023-01-01",
"port-version": 0
},
"ezc3d": {
"baseline": "1.5.11",
Expand Down
5 changes: 5 additions & 0 deletions versions/e-/exprtk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "2238b012e3497cfa5bca47a39f3975e15b960d1b",
"version-date": "2023-01-01",
"port-version": 0
},
{
"git-tree": "f643b034afeb28a7e39b6556eb78594aa49181a4",
"version-date": "2022-01-01",
Expand Down
Loading