-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom DKIM selector #2349
custom DKIM selector #2349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work.
b51550d
to
6e2c653
Compare
@JoshData is this ok? |
I would like to avoid using /etc/mailinabox.conf for new settings and put the settings in $STORAGE_ROOT, e.g. $STORAGE_ROOT/mail/dkim/selector.txt. /etc/mailinabox.conf isn't included in backups and was meant for really low-level settings needed to do automated installs like the IP address. |
ok, let me take a look as it has been a while :) |
I had a look. Using How about |
I'm of the view that this is the best way forward and have filed a PR to demonstrate it. This would mean, we still have to add all settings into Does this address all your concerns? Thank you! |
6e2c653
to
48bda15
Compare
48bda15
to
7df6b00
Compare
also brought this PR up to v68, ready to be merged |
|
Fixes #2348
Allows us to avoid a DKIM TXT record clash when in use with other sending servers. Thank you.