Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify a custom DKIM selector #2383

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bilogic
Copy link
Contributor

@bilogic bilogic commented Apr 21, 2024

To make it easier for the reviewer(s),

  1. auto format commits have no changes in logic
  2. a7beb72 and before are for PR Allow user to overwrite config using $STORAGE_ROOT/mailinabox.conf #2382
  3. DKIM selector code changes are found in only 1 commit 12f1486, which basically replaces the hardcoded selector with a variable

@JoshData
Copy link
Member

Sorry I'm not going to allow putting the setting in mailinabox.conf. It has to go somewhere in STORAGE_ROOT so that it's backed up.

@bilogic
Copy link
Contributor Author

bilogic commented Dec 23, 2024

Ok, how about STORAGE_ROOT/config.d/override.conf?

It would be great to get faster feedback. I had to read up what this was all about before being able to answer. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants