Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable TTL #2352

Closed
wants to merge 2 commits into from
Closed

Conversation

bilogic
Copy link
Contributor

@bilogic bilogic commented Jan 6, 2024

makes the TTL default of 86400, but configurable for those who need some form of DDNS

  1. The custom DKIM selector PR affect the same files as this PR and require human merging custom DKIM selector #2349
  2. If both PRs are acceptable, can consider getting from my custom branch instead https://github.com/bilogic/mailinabox/tree/custom

Thanks!

@jvolkenant
Copy link
Contributor

This only changes the default ttl, which you probably don't want to change if you just want a similar DDNS functionality as this changes the TTL for all records (Including NS which probably isn't great to be very short). You can actually do short TTL on the records themselves. See main...jvolkenant:mailinabox:02-customttl as an example.

There should also be some some GUI way to set a lower TTL, or documentation done on the mailinabox site explaining to users how to set this.

The additional auto formatting changes are unnecessary. They don't fix any broken functionality and only mask git blames

@bilogic
Copy link
Contributor Author

bilogic commented Jan 16, 2024

Thanks for the feedback!

  1. I will review the TTL example once I'm at my desk
  2. I suppose no auto formatter was used on this project and always found them very helpful, is there a way to introduce one?

@bilogic
Copy link
Contributor Author

bilogic commented Apr 23, 2024

no longer economical to merge this due to the huge commits in between

@bilogic bilogic closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants