-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anamorphic Bloom #17096
base: main
Are you sure you want to change the base?
Anamorphic Bloom #17096
Conversation
7b020db
to
0b518bb
Compare
0b518bb
to
06806b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just style changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending SME feedback / benchmarking.
I don't have time to benchmark right now, but if someone benchmarks this and it shows no perf impact then the code LGTM. I'd just like to see some numbers first. My guess is that if there's an impact it will be pretty small, but would still be nice to know. |
I added a shader def, so the fast path should still exist, and the new code is only compiled in when using nonuniform bloom scale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the ifdef I'm happy to merge it without benchmarking, but it would be nice to have numbers and yeet the ifdef if it's not necessary.
I'd like to try messing with the weights instead. After fixing the upscaling issue, non uniform blur looks worse because it can't rely on incorrect upsamples misaligned with the frags. |
68eb4a6
to
f33cb02
Compare
I couldn't find a decent path with weights without making more significant changes. I think this is good as-is now. I've tested with the car scene again with the latest settings, and I'm happy with how it looks. |
Screen.Recording.2025-01-02.at.1.22.57.AM.mp4
The JJ Abrahams
Screen.Recording.2025-01-02.at.9.56.21.AM.mp4
The Cyberfunk 2025
Objective
Solution
Testing
bloom_3d
/bloom_2d
exampleShowcase
scale
parameter toBloom
to improve artistic control and enable anamorphic bloom.