Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: composablesセクションのハンズオン資料作成 #16

Merged
merged 11 commits into from
Jun 8, 2024

Conversation

shiyuu33
Copy link
Collaborator

@shiyuu33 shiyuu33 commented May 26, 2024

修正概要

composablesセクションのハンズオン資料作成を作成しました。

備考

EH側はcomposition api ですが、JP側はnuxtのcomposablesの内容にする方針になりました

close #6

@shiyuu33 shiyuu33 self-assigned this May 26, 2024
@ubugeeei ubugeeei changed the title feat(wip): composablesセクションのハンズオン資料作成 [WIP] feat: composablesセクションのハンズオン資料作成 Jun 4, 2024
@shiyuu33 shiyuu33 changed the title [WIP] feat: composablesセクションのハンズオン資料作成 feat: composablesセクションのハンズオン資料作成 Jun 8, 2024
Copy link
Member

@ubugeeei ubugeeei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 点だけコメントしました!(同じ内容のものは省略しています)

@@ -0,0 +1,18 @@
<script setup lang="ts">
const count = ref<number>(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ジェネリクス渡さなくていいと思います

- const count = ref<number>(1)
+ const count = ref(1)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ubugeeei
外しました!
325805b

<div>
<p>count is {{ count }}</p>
<p>doubled is {{ doubled }}</p>
<button @click="increment">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type="button" をつけて欲しいです!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ubugeeei
修正しました!
他の箇所も統一したいですね👀
603a978

@shiyuu33 shiyuu33 requested a review from ubugeeei June 8, 2024 15:45
@ubugeeei ubugeeei merged commit 5ea7ce2 into main Jun 8, 2024
2 checks passed
@ubugeeei ubugeeei deleted the feature/add_composables branch June 8, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite contents of Vue Composition API to Composables
2 participants