Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: content/1.vue/3.reactivity-2 #30

Merged
merged 5 commits into from
Jun 15, 2024
Merged

feat: content/1.vue/3.reactivity-2 #30

merged 5 commits into from
Jun 15, 2024

Conversation

aster-mnch
Copy link
Collaborator

close #5

前章で触れられていたように、reactive, watch の説明を追加しています

@aster-mnch aster-mnch self-assigned this Jun 9, 2024
@aster-mnch aster-mnch force-pushed the reactivity-2 branch 2 times, most recently from 9247164 to 2f149f3 Compare June 9, 2024 11:05
@aster-mnch aster-mnch changed the title [wip] feat: content/1.vue/3.reactivity-2 feat: content/1.vue/3.reactivity-2 Jun 9, 2024
@aster-mnch aster-mnch requested a review from ubugeeei June 9, 2024 11:10
Copy link
Collaborator Author

@aster-mnch aster-mnch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

セルフコメ

content/1.vue/3.reactivity-2/index.md Show resolved Hide resolved
content/1.vue/3.reactivity-2/.template/files/app.vue Outdated Show resolved Hide resolved
content/1.vue/3.reactivity-2/.template/files/app.vue Outdated Show resolved Hide resolved
content/1.vue/3.reactivity-2/index.md Outdated Show resolved Hide resolved
@aster-mnch
Copy link
Collaborator Author

(Slack でメンションしようと思ったら速攻で Emoji reaction きたwww)

Copy link
Member

@ubugeeei ubugeeei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aster-mnch

いくつかコメントしてみましたが、それはそれとして「そもそも reactive ってもう説明しなくてもいいんじゃないか、チュートリアルだし」という気持ちが出てきてしまったので別の issue にしてみました -> #31

どこかで考えよう... 😔

content/1.vue/3.reactivity-2/.template/files/app.vue Outdated Show resolved Hide resolved
content/1.vue/3.reactivity-2/index.md Outdated Show resolved Hide resolved
content/1.vue/3.reactivity-2/.template/solutions/app.vue Outdated Show resolved Hide resolved
@aster-mnch
Copy link
Collaborator Author

@ubugeeei
レビューもらってから時間空いて申し訳ないです 🙏
指摘部の修正・対応 push しました。

「そもそも reactive ってもう説明しなくてもいいんじゃないか、チュートリアルだし」という気持ちが出てきてしまったので別の issue にしてみました -> #31

正直書いてても reactive の細かい説明はなくてもいい気はしました。
個人的に #30 (comment) はどこかで触れたい気もしますが、content/1.vue/2.reactivity に一文追加でも良さそうなので、3.reactivity-2 の章は watch (とライフサイクルあたり?) に絞っても良さそうではあります。

とりあえずこの PR 内では reactive は残したまま書いています。

@aster-mnch aster-mnch requested a review from ubugeeei June 15, 2024 01:40
@ubugeeei ubugeeei merged commit 020627a into main Jun 15, 2024
2 checks passed
@ubugeeei ubugeeei deleted the reactivity-2 branch June 15, 2024 01:41
@aster-mnch
Copy link
Collaborator Author

早い早い早い

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactivity Part 2
2 participants