-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Docker for Development #88
Merged
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
1a9759d
Set up Dockerfile, docker-compose.ym, and .dockerignore
gaylem 5856b68
Add comment
gaylem 0b1823f
Merge branch 'main' into feature/docker
gaylem 1c5323c
Update comments
gaylem 523251b
Merge branch 'main' into feature/docker
gaylem d94e30c
Update Dockerfile
gaylem f56fe03
Update Dockerfile
gaylem 5cc112a
Remove volumes from docker-compose.yml
gaylem 921feed
Update README
gaylem e1ef311
Update README.md
gaylem ba49a65
Merge branch 'main' into feature/docker
gaylem 1f08ca9
Update README.md
gaylem b510b39
Add bash shell instructions to README
gaylem aa54be1
Merge branch 'feature/docker' of https://github.com/gaylem/electrify-…
gaylem b693676
Update README.md
gaylem 92f9372
Update README.md
gaylem f4ac584
Remove MacOS known error since Docker should resolve this
gaylem 2dcf7cf
Update README.md
gaylem 957285d
Update README.md
gaylem 7cf7771
Update README.md
gaylem c4d7be4
Update README.md
gaylem f345324
Update README.md
gaylem 7925159
Update README.md
gaylem 5a5e4ec
Change COPY . ./ to COPY . ./app
gaylem ff5c79d
Create docker-entrypoint.sh
gaylem 6b5c2b1
Add entrypoint
gaylem 8f68f86
Revert Dockerfile
gaylem 8a910fa
Revert docker-compose.yml
gaylem 6530463
Delete docker-entrypoint.sh
gaylem a34b08d
Update README
gaylem eb96599
Cleaned up Dockerfile to reduce number of layers and image size
gaylem d355918
Add volumes back in so that changes display on browser
gaylem 1b5e322
Add command to docker-compose.yml to enable hot reloading
gaylem d7bf7d7
Update README
gaylem e069adc
Add newline to EOF
vkoves File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
node_modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
FROM python:3.9 | ||
|
||
# Add the NodeSource PPA | ||
RUN echo 'Package: nodejs\nPin: origin deb.nodesource.com\nPin-Priority: 600' > /etc/apt/preferences.d/nodesource \ | ||
&& curl -fsSL https://deb.nodesource.com/setup_16.x | bash - \ | ||
&& apt-get update \ | ||
&& apt-get install -y nodejs | ||
|
||
# Install yarn | ||
RUN npm install -g yarn | ||
|
||
# Set working directory | ||
WORKDIR /app | ||
|
||
# Copy requirements and dependency files to the working directory | ||
COPY requirements.txt . | ||
COPY package.json . | ||
COPY yarn.lock . | ||
|
||
# Copy the rest of the application code | ||
COPY . . | ||
|
||
# Install Python dependencies | ||
RUN pip install --no-cache-dir -r requirements.txt | ||
|
||
# Install dependencies | ||
RUN yarn install | ||
|
||
# Expose the port that the app runs on | ||
EXPOSE 8080 | ||
|
||
# Start the app in development mode | ||
CMD ["yarn", "develop"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
version: '3.8' | ||
|
||
services: | ||
electrify-chicago: | ||
image: electrify-chicago:latest | ||
build: | ||
context: . | ||
dockerfile: Dockerfile | ||
ports: | ||
- "8080:8080" | ||
volumes: | ||
- .:/app | ||
- /app/node_modules | ||
command: yarn develop |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
. .
? Is that different than just./
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nevermind it's the arguments to copy, an input to output.