-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Docker for Development #88
Conversation
✅ Deploy Preview for radiant-cucurucho-d09bae ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Welp, I'm getting the following error now:
It looks like my /app directory isn't showing up in my container:
Here's my current Dockerfile. I've moved some things around, but the error stays the same.
If anyone has any ideas let me know, otherwise we can take a look at it next week. |
Hey again, I went ahead and created a stack overflow about this, sharing here in case anyone wants to follow: https://stackoverflow.com/questions/78281569/error-bin-sh-1-gridsome-not-found-after-docker-image-build |
@gaylem - great use of StackOverflow, I saw someone already responded in comments! 🥳 |
@vkoves I know I just saw!! I'm putting the finishing touches on things now 😄 |
All righty, I was able to run my container locally and view the site! So this should be ready for review 🥳 |
@gaylem - could you document in the |
@vkoves yeah no problem, I'll look into it! |
…chicago into feature/docker
@vkoves I updated the instructions and was able to run |
@vkoves I managed to get all the tests working in the bash shell!! Couldn't figure out the entrypoint approach, though. I think this is good for now and we can always open a new issue to improve it. Let me know what you think! |
@gaylem - if you change data, Gridsome has to be restarted. Would |
@vkoves Ohhh I'm not totally sure. The internet said this: "The ‘docker-compose stop’ command merely halts running containers without removing them. In contrast, ‘docker-compose down’ goes a step further to stop and also discard the containers and the networks they were utilizing." So It would probably be faster to just use I don't know how to change data yet. Maybe you can show me how on Tuesday and we can test it out? Also happy to pair up before then if you're available. |
@gaylem - it turns out changing any queries (e.g. change |
COPY yarn.lock . | ||
|
||
# Copy the rest of the application code | ||
COPY . . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why . .
? Is that different than just ./
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nevermind it's the arguments to copy, an input to output.
@derekeder from QA this looks good to me, but do you mind just checking out the Docker config, since you're more of an expert? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pulled this down locally and confirmed it builds and runs for me. looks good to bring in!
@derekeder Huzzah!! Thanks for reviewing! I tried to get your entrypoint suggestions to work but I just couldn't wrap my head around it. Maybe at Hack Night we can talk through it again and see if there are more improvements that can be made, and I'll raise another issue for them. |
sounds good! |
@gaylem and @derekeder - all set! |
thx. PR opened: #90 |
Description
We want to streamline our setup process for our developers and improve our version control by setting up Docker for electrify-chicago. Changes made:
Fixes #84
Testing Instructions
Run
docker-compose up
You should see the following in your terminal and be able to view the site at http://localhost:8080
Open up a bash shell in the Docker container by running
docker-compose exec electrify-chicago bash
and then test the linting and data processing commands in the updated README.Review the README and confirm if the instructions are accurate.
Make a change on the frontend to confirm changes are visible in development. It's a little slow, but if you wait a second it should update on the client automatically.
Checklist: