feat: add Checkbox component #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rafael Toledo <[email protected]> Co-authored-by: root <root@DESKTOP-IBCJMH9> Co-authored-by: Nitesh Singh <[email protected]>
gitstart
changed the title
|
👋 Hello @mitrotasios! Can you review this PR, please? |
|
hey @gitstart thanks for the work! 🥳 I think we will release v3 before we will add any new components. V3 will be released in the next week probably, so I would review / merge this PR afterwards :) |
…-checkbox-component
Co-authored-by: Nitesh Singh <[email protected]> Co-authored-by: Rafael Toledo <[email protected]> Co-authored-by: root <root@DESKTOP-IBCJMH9>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Is this little guy in some beta release? |
|
Hi @Lary15, not yet but later this month. |
|
Updating Beta branch |
14 tasks
christopherkindl
approved these changes
Dec 5, 2023
severinlandolt
added
the
PR: In Review
|
🎉 This PR is included in version 3.12.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @severinlandolt . When will it be released to main branch? |
|
Hey @kronos1345, is a breaking change so no earlier than v.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #456
What: Create a Checkbox component
Why: To be possible to add a Checkbox component using the tremor lib
How: The changes was implemented following the other component as a base, was created a new folder on input-element called CheckBox with this changes. Also was created a test file and a .stories file
Tests:
Custom CheckBox example:
Testing
run:
Search for CheckBox in "InputElements" folder
Demo
Loom video with the changes using the created page component as example and with the component on storybook:
https://www.loom.com/share/136cc8da195a42ec84e1c2c6551da9c6
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.