feat: Partial donut or pie chart #494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rafael Toledo <[email protected]> Co-authored-by: root <root@DESKTOP-IBCJMH9>
gitstart
changed the title
|
Hey @mitrotasios! Could you kindly review this PR, please? |
|
Thanks for this, will review after v3 :) |
gitstart
force-pushed
the
feat/add-partial-donut-component
branch
3 times, most recently
from
1717409 to
07d9579
Compare
Co-authored-by: Rafael Toledo <[email protected]> Co-authored-by: root <root@DESKTOP-IBCJMH9>
gitstart
force-pushed
the
feat/add-partial-donut-component
branch
from
07d9579 to
8a88b38
Compare
|
Hello @mitrotasios. Hope you are well. |
|
Cf. #474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo
Loom Video: https://www.loom.com/share/7fa1765cc095433e90b10558a773da16
Related Issue
Fixes #474
What
Add props to the user customize the donuts/pies
Why
to be possible to set custom angles to this component
How
Set the props startAngle and percentage as values passed by the user
Testing
run:
Go to ChartElements/DonutChart
Go to "Custom Size Template" and change the props startAngle
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.