Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en: Update and normalize locale file #1088

Closed
wants to merge 1 commit into from

Conversation

jlduran
Copy link
Contributor

@jlduran jlduran commented Jun 4, 2023

Leave the %{count} changes to 1 for another PR (requires further discussion).

Copy link
Contributor

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes! Can you add an entry to the CHANGELOG?

@jlduran jlduran force-pushed the update-and-normalize-en branch from 8c1c58b to bbdecf5 Compare June 4, 2023 20:17
@jlduran
Copy link
Contributor Author

jlduran commented Jun 4, 2023

Thank you! CHANGELOG updated.
Let me know if there's something else missing.

@pama
Copy link
Collaborator

pama commented Jun 5, 2023

@jlduran could you fix the conflict?

@jlduran jlduran force-pushed the update-and-normalize-en branch from bbdecf5 to 0810838 Compare June 5, 2023 23:50
@jlduran
Copy link
Contributor Author

jlduran commented Jun 5, 2023

Done! Thank you!

@pama
Copy link
Collaborator

pama commented Jun 14, 2023

I'm not considering accepting this PR immediately because it introduces a new entry that won't be available before Rails 7.1.

I might fix or revert #1086 due to the same reason.

@jlduran
Copy link
Contributor Author

jlduran commented Jun 14, 2023

I'm not considering accepting this PR immediately because it introduces a new entry that won't be available before Rails 7.1.

I might fix or revert #1086 due to the same reason.

OK. That’s a valid reason. I have an idea. I’ll update this PR with it. Thank you!

@jlduran
Copy link
Contributor Author

jlduran commented Jun 14, 2023

@pama Proposed #1091. I'll rebase this pull request if it gets accepted. Thank you for pointing this out.

@jlduran jlduran force-pushed the update-and-normalize-en branch from 0810838 to 2929d88 Compare June 23, 2023 17:11
@jlduran
Copy link
Contributor Author

jlduran commented Jun 23, 2023

#1091 has been merged.
This pull request is a trivial cosmetic one now. I'll leave it here just in case, but it can be closed now.

Thank you!

@jlduran
Copy link
Contributor Author

jlduran commented Jun 24, 2023

This can be closed now. Thank you!

@jlduran jlduran closed this Jun 24, 2023
@jlduran jlduran deleted the update-and-normalize-en branch June 24, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants