Update rails update script #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunny
reviewed
Jun 4, 2023
| @@ -4,37 +4,37 @@ | |||
| distance_in_words: | |||
| half_a_minute: "half a minute" | |||
| less_than_x_seconds: | |||
| one: "less than %{count} second" | |||
| one: "less than 1 second" | |||
There was a problem hiding this comment.
The decision to prefer %{count} was discussed in #993
There was a problem hiding this comment.
Correct, that is why #1088 leaves them as they are.
These changes are verbatim from https://github.com/rails/rails/blob/main/actionview/lib/action_view/locale/en.yml
This file does not belong to this project, it is only used as a reference.
|
I have updated the description to further clarify the changes, and state that the files we are changing are under |
sunny
approved these changes
Jun 4, 2023
pama
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update.rbscript downloads the locale files from rails/rails.These files are merged and normalized into a single
en.yml, which serves as the basis for this gem.This pull request updates the
update.rbscript, by pointing it to the correct branch from the Rails project. Also, updates the latest version of each locale file underrails/rails. It is important to note that these files are external to this gem, and only the keys are used for comparison.