[PQC] Add support for mlkem768x25519-sha256 key exchange method #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-xu
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
scott-xu
commented
Dec 27, 2024
| @@ -22,6 +22,22 @@ public void TearDown() | |||
| _remoteSshdConfig?.Reset(); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| [Ignore] | |||
There was a problem hiding this comment.
The OpenSSH at Ubuntu is not the latest version.
My local test passed with OpenSSH 9.9p1.
scott-xu
force-pushed
the
kex_mlkem768x25519-sha256
branch
2 times, most recently
from
2456def to
579b27c
Compare
scott-xu
force-pushed
the
kex_mlkem768x25519-sha256
branch
2 times, most recently
from
31bd6d5 to
a86d117
Compare
scott-xu
force-pushed
the
kex_mlkem768x25519-sha256
branch
from
a86d117 to
8ad445e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for mlkem768x25519-sha256 hybrid post-quantum key exchange method based on the FIPS 203 Module-Lattice Key Encapsulation mechanism (ML-KEM) combined with X25519 ECDH as described by https://www.ietf.org/archive/id/draft-kampanakis-curdle-ssh-pq-ke-05.html
OpenSSH added support for this key exchange method in release 9.9, see https://www.openssh.com/txt/release-9.9.