Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hybrid key exchange methods #302

Open
scott-xu opened this issue Dec 27, 2024 · 2 comments · May be fixed by #311
Open

Add support for hybrid key exchange methods #302

scott-xu opened this issue Dec 27, 2024 · 2 comments · May be fixed by #311

Comments

@scott-xu
Copy link
Contributor

scott-xu commented Dec 27, 2024

Suggest adding support for sntrup761x25519-sha512 and mlkem768x25519-sha256 key exchange method which is described at https://www.ietf.org/archive/id/draft-ietf-sshm-ntruprime-ssh-01.html and https://www.ietf.org/archive/id/draft-kampanakis-curdle-ssh-pq-ke-05.html

I created 2 PRs in SSH.NET. See sshnet/SSH.NET#1562 and sshnet/SSH.NET#1563

@tmds Let me know if you want me port the two PRs to this repository.

@tmds
Copy link
Owner

tmds commented Dec 27, 2024

@scott-xu it would be very interesting to have support for this, and thank you for offering to implement it!

I'm not sure if the abstractions we have are fit to plug this in. We'll figure that out as we go.
Let's start with sntrup761x25519-sha512, and tackle mlkem768x25519-sha256 after that.

For tests, please add something like https://github.com/tmds/Tmds.Ssh/blob/main/test/Tmds.Ssh.Tests/HostKeyAlgorithmTests.cs but for setting KeyExchangeAlgorithms instead of ServerHostKeyAlgorithms.

I'm finishing off some things to make a December release, and this can be part of the January release.

@scott-xu
Copy link
Contributor Author

Let me try curve25519-sha256 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants