Search wheels for .dist-info directories
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
force-pushed
the
search-distinfo
branch
from
a2ab99f to
80e8660
Compare
stefanor
commented
Aug 16, 2022
|
Is there anything I can do to help get this merged? I've been running into this problem when using bazel to install wheels with capitalization issues. |
stefanor
changed the title
|
Ping? |
pradyunsg
previously approved these changes
Dec 5, 2022
src/installer/utils.py
Outdated
| @@ -93,6 +93,14 @@ def parse_metadata_file(contents: str) -> Message: | |||
| return feed_parser.close() | |||
|
|
|||
|
|
|||
| def normalize_distribution_name(name: str) -> str: | |||
There was a problem hiding this comment.
Hmm... this might be easier to parse for folks if this has the same name as the packaging function.
Suggested change
| def normalize_distribution_name(name: str) -> str: | |
| def canonicalize_name(name: str) -> str: |
src/installer/sources.py
Outdated
Comment on lines
143
to
144
| norm_di_dname = normalize_distribution_name(di_dname) | ||
| norm_file_dname = normalize_distribution_name(self.distribution) |
There was a problem hiding this comment.
Suggested change
| norm_di_dname = normalize_distribution_name(di_dname) | |
| norm_file_dname = normalize_distribution_name(self.distribution) | |
| norm_di_dname = canonicalize_name(di_dname) | |
| norm_file_dname = canonicalize_name(self.distribution) |
pradyunsg
force-pushed
the
search-distinfo
branch
from
80e8660 to
ac40283
Compare
|
TestWheelFile.test_finds_dist_info is failing on 3.7. |
pradyunsg
dismissed
their stale review
This PR needs fixes for the failure identified in CI.
Some wheels don't use canonicalized names for their .dist-info directories, so search the wheel for them. Fixes: pypa#134
At least, once they are both normalized.
|
Applied your name suggestion, and rebased on top of master.
Added a workaround for that in a separate commit, that's easy to revert later. |
stefanor
force-pushed
the
search-distinfo
branch
from
ac40283 to
49e86a4
Compare
for more information, see https://pre-commit.ci
pradyunsg
approved these changes
Dec 13, 2022
pradyunsg
changed the title
.dist-info directories
pradyunsg
pushed a commit
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some wheels don't use normalized names for their
.dist-infodirectories, so search the wheel for them.Fixes: #134