Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make follow up improvements to WheelSource.dist_info_dir #157

Closed
pradyunsg opened this issue Dec 13, 2022 · 0 comments · Fixed by #168
Closed

Make follow up improvements to WheelSource.dist_info_dir #157

pradyunsg opened this issue Dec 13, 2022 · 0 comments · Fixed by #168
Assignees
@pradyunsg
Labels
component: sources Related to WheelSource and friends type: task Something that needs to be done that is not a bug or feature

Comments

@pradyunsg
Copy link
Member

This is a follow up to #137.

  • Instead of hasattr dynamicism, use an _dist_info_dir: Optional[str] attribute.
  • Replace assert with rich/proper error objects that can be introspected.
@pradyunsg pradyunsg added the type: task Something that needs to be done that is not a bug or feature label Dec 13, 2022
@pradyunsg pradyunsg mentioned this issue Dec 13, 2022
Merged
@pradyunsg pradyunsg self-assigned this Dec 13, 2022
@pradyunsg pradyunsg added the component: sources Related to WheelSource and friends label Dec 13, 2022
@pradyunsg pradyunsg mentioned this issue Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pradyunsg pradyunsg

Labels
component: sources Related to WheelSource and friends type: task Something that needs to be done that is not a bug or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve handling of non-normalized .dist-info folders pypa/installer
1 participant
@pradyunsg