Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Active-set-based Language #511

Closed
wants to merge 14 commits into from

Conversation

kwaters4
Copy link
Contributor

Goal

Place all active set language in deprecated blocks. Since the 1.5 specification has been released, active set language has been deprecated. There are were elements of the documents that did not reflect this. With this update "deprecated" blocks can be removed and the teams based collectives can stand on their own with have active set language interleaved in them. This tackles issue #504. Some language is duplicated in the document, however it is within a deprecate block. No API changes are intended, just spec cosmetics.

Changes

Programing Model

  • Updated programming model to have the Collective Communication All-to-All section reflect the shift to teams from active set.

Collective Introduction

  • Added an additional item to the collective intro to separate active set and team collectives.

Collective Operations

  • Modified API arguments desciption from "each PEs in the active set" to "PEs in the participating PEs"
  • Separated language in API description to contain a team based section and a now deprecated active set section. Some language is duplicated for ease of removal for later.
  • Functions modified 'alltoall', alltoalls, broadcast, collect/fcollect, sync, reductions

Team Split Strided

  • The notes for shmem_team_split_strided had a reference to active set language, where strided must be a power of two for the now deprecated active base language.

Tex Formatting

  • shmem_malloc_with_hints table had a breaking \newline within it. Could not compile the document with the lines in it. Removal had no consequences seen by the author.
  • Fixed formatting issue in Return Values function that prevented a DeprecateBlock to be used with in the Return Values environment. This was needed for shmem_collect, which changed its return value with team based collectives.

@kwaters4 kwaters4 changed the title Update/Deprecate Active-set-based Language Deprecate Active-set-based Language Mar 28, 2024
@davidozog davidozog added this to the OpenSHMEM 1.6 milestone Apr 4, 2024
content/shmem_reductions.tex Outdated Show resolved Hide resolved
content/collective_intro.tex Outdated Show resolved Hide resolved
content/shmem_team_split_strided.tex Outdated Show resolved Hide resolved
content/shmem_broadcast.tex Outdated Show resolved Hide resolved
the data has been copied out of the \VAR{source} data object.
\item For active-set-based routines,
the values in the \VAR{pSync} array are restored to the original values.
\item Its \VAR{dest} symmetric data object is completely updated and the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: Whitespace

@jdinan
Copy link
Collaborator

jdinan commented Sep 26, 2024

Merged into collectives section committee RC1

@kwaters4 Please reopen if I got it wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Collectives (Sec. 9.10)
Development

Successfully merging this pull request may close these issues.

3 participants