-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Active-set-based Language #511
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwaters4
changed the title
Update/Deprecate Active-set-based Language
Deprecate Active-set-based Language
Mar 28, 2024
davidozog
reviewed
Apr 25, 2024
Typo Co-authored-by: David Ozog <[email protected]>
White Space Co-authored-by: David Ozog <[email protected]>
Typo, uppercase
kwaters4
commented
Jul 26, 2024
content/shmem_alltoall.tex
Outdated
the data has been copied out of the \VAR{source} data object. | ||
\item For active-set-based routines, | ||
the values in the \VAR{pSync} array are restored to the original values. | ||
\item Its \VAR{dest} symmetric data object is completely updated and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix: Whitespace
Merged into collectives section committee RC1 @kwaters4 Please reopen if I got it wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Place all active set language in deprecated blocks. Since the 1.5 specification has been released, active set language has been deprecated. There are were elements of the documents that did not reflect this. With this update "deprecated" blocks can be removed and the teams based collectives can stand on their own with have active set language interleaved in them. This tackles issue #504. Some language is duplicated in the document, however it is within a deprecate block. No API changes are intended, just spec cosmetics.
Changes
Programing Model
All-to-All
section reflect the shift to teams from active set.Collective Introduction
Collective Operations
alltoalls
,broadcast
,collect/fcollect
,sync
,reductions
Team Split Strided
shmem_team_split_strided
had a reference to active set language, where strided must be a power of two for the now deprecated active base language.Tex Formatting
shmem_malloc_with_hints
table had a breaking \newline within it. Could not compile the document with the lines in it. Removal had no consequences seen by the author.Return Values
function that prevented aDeprecateBlock
to be used with in theReturn Values
environment. This was needed forshmem_collect
, which changed its return value with team based collectives.