Clarifying Team Collectives #452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdinan
reviewed
Oct 5, 2020
| @@ -1,6 +1,6 @@ | |||
| \apisummary{ | |||
| The following functions perform reduction operations across all | |||
| \acp{PE} in a set of \acp{PE}. | |||
| \acp{PE} in an \openshmem team or active set of \acp{PE}. | |||
There was a problem hiding this comment.
Would the sentence read better if we dropped "of \acp{PE}"?
There was a problem hiding this comment.
Also suggest dropping "of PEs" in the subsequent occurrences.
|
@davidozog Could you please review this PR to see if the collectives section committee would like to incorporate these changes? |
|
Most all these changes are apparently now covered by #511, but perhaps we should check with @kwaters4 before closing this PR. @kwaters4 - the changes on this PR in |
|
Closed by davidozog#8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some descriptions of collective routines did not specify support for OpenSHMEM teams, but rather only active sets. These changes clarify that they support both teams and active sets (now deprecated).