update metrics service prometheus port annotation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Service port is not used for scraping. The actual Endpoints resources part of Service are at 9117 (targetPort/containerPort). The best practice for scraping metrics is to do that against Pods and/or Endpoints, not Services ports directly. It is known to cause issues if more than one endpoint is behind the service, as metric queries will be load-balanced as well leading to inaccurate histograms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a comment next to the annotations to make it more clear how this is apparently suppose to work.
A copy of #18 because the original author @wreis closed it and deleted the branch (understandably, after a long time in apparent limbo).
For users of this chart, that enable prometheus metrics and don't customize the ports, nothing actually changes - because the service port and pod port matches by default.