Skip to content

Commit

Permalink
Merge pull request #20 from nsqio/prom_port_anno
Browse files Browse the repository at this point in the history
update metrics service prometheus port annotation
  • Loading branch information
ploxiln authored Nov 1, 2024
2 parents bed43d1 + 90b0902 commit c100819
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/nsq/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: nsq
description: A realtime distributed messaging platform
type: application
version: 0.0.10
version: 0.0.11
appVersion: 1.2.1
home: https://github.com/nsqio/helm-chart/tree/master/charts/nsq
icon: https://nsq.io/static/img/nsq_blue.png
Expand Down
6 changes: 5 additions & 1 deletion charts/nsq/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,12 @@ metrics:

service:
annotations:
# Prometheus does not connect to this service directly,
# instead it uses this port to connect to each target
# of the service (each nsqd).
# TODO: remove service and annotate pods instead?
prometheus.io/scrape: "true"
prometheus.io/port: "{{ .Values.metrics.service.ports.metrics }}"
prometheus.io/port: "{{ .Values.metrics.containerPort }}"
prometheus.io/path: "/metrics"
type: ClusterIP
ports:
Expand Down

0 comments on commit c100819

Please sign in to comment.