Dynamisk g vedtaksbrev #2435
Merged
Dynamisk g vedtaksbrev #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. Trenger derfor ikke å oppdatere grunnbeløp i både frontend og backend.
gunnsteingarmo
requested review from
charliemidtlyng,
ViktorGSolberg,
olekvernberg,
ma10s and
throndi
olekvernberg
approved these changes
Oct 11, 2023
| val periode: Månedsperiode, | ||
| val grunnbeløp: BigDecimal, | ||
| val grunnbeløpMåned: BigDecimal, | ||
| val gjennomsnittPerÅr: BigDecimal? = null, |
There was a problem hiding this comment.
Trenger kanskje ikke denne?
Har snakket om at den kan fjernes fra Grunnbeløp-klassen i ef-sak også
| @@ -53,4 +54,11 @@ class BeregningController( | |||
| ?: error("Fant ingen startdato for vedtak på behandling med id=$behandlingId") | |||
| return Ressurs.success(tilkjentYtelseService.hentForBehandling(behandlingId).tilBeløpsperiode(startDatoForVedtak)) | |||
| } | |||
|
|
|||
| @GetMapping("/grunnbelopForPerioder") | |||
| fun hentNyesteGrunnbeløpOgAntallGrunnbeløpsperioderTilbakeITid(@RequestParam antall: Int): Ressurs<List<GrunnbeløpDTO>> { | |||
There was a problem hiding this comment.
Er det et behov noen sted å returnere flere G-beløp?
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hvorfor er denne endringen nødvendig? ✨
Har laget et endepunkt for å hente grunnbeløp. Det er for å minimere antall stedet vi må lagre og oppdatere grunnbeløp. Nå er det kun behov for å oppdatere det i ef-sak, vi kan derfor slutte å gjøre det i ef-sak-frontend og Sanity. Noe som også kan bidra til mindre feil i fremtiden hvis vi glemmer å oppdatere disse.
Frontend: navikt/familie-ef-sak-frontend#2587
Favro: https://favro.com/organization/98c34fb974ce445eac854de0/a64c6aad9b0d61ef6c0290bd?card=NAV-14507