Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamisk g vedtaksbrev #2587

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Dynamisk g vedtaksbrev #2587

merged 8 commits into from
Oct 17, 2023

Conversation

gunnsteingarmo
Copy link
Contributor

Hvorfor er denne endringen nødvendig? ✨

Henter grunnbeløp fra et endtepunkt i backend navikt/familie-ef-sak#2435
Har laget en hook for å hente en liste med grunnbeløpsperioder. Denne brukes to steder. Først for å sette 6 ganger grunnbeløpet i Sanity, også har den tatt over for en hardkodet liste i GrunnbeløpInfo. Det vil bli enklere å holde grunnbeløp oppdatert, da dette kun skal sette i backend fremover.

Favro: https://favro.com/organization/98c34fb974ce445eac854de0/a64c6aad9b0d61ef6c0290bd?card=NAV-14507
image

@@ -0,0 +1,37 @@
import { Ressurs } from '@navikt/familie-typer';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mangler en "n" i filnavnet (Grunbeløp)

Copy link
Contributor

@olekvernberg olekvernberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gunnsteingarmo gunnsteingarmo merged commit 14795a9 into master Oct 17, 2023
3 checks passed
@gunnsteingarmo gunnsteingarmo deleted the dynamisk-g-vedtaksbrev branch October 17, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants