-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 5 NuGet dependencies #331
Update 5 NuGet dependencies #331
Conversation
Bumps nanoFramework.Iot.Device.Button from 1.2.552 to 1.2.560</br>Bumps nanoFramework.System.Device.Gpio from 1.1.38 to 1.1.41</br>Bumps nanoFramework.System.Device.Spi from 1.3.48 to 1.3.52</br>Bumps nanoFramework.Iot.Device.Bmm150 from 1.2.552 to 1.2.560</br>Bumps nanoFramework.Iot.Device.Axp192 from 1.2.548 to 1.2.560</br> [version update] ###⚠️ This is an automated update.⚠️
WalkthroughThe changes involve updating the versions and content hashes of various Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (38)
Tests/AtomLiteTestApp/AtomLiteTestApp.nfproj
is excluded by none and included by noneTests/AtomLiteTestApp/packages.config
is excluded by none and included by noneTests/AtomMatrixTestApp/AtomMatrixTestApp.nfproj
is excluded by none and included by noneTests/AtomMatrixTestApp/packages.config
is excluded by none and included by noneTests/FireTestApp/FireTestApp.nfproj
is excluded by none and included by noneTests/FireTestApp/packages.config
is excluded by none and included by noneTests/M5Core2TestApp/M5Core2TestApp.nfproj
is excluded by none and included by noneTests/M5Core2TestApp/packages.config
is excluded by none and included by noneTests/M5CoreTestApp/M5CoreTestApp.nfproj
is excluded by none and included by noneTests/M5CoreTestApp/packages.config
is excluded by none and included by noneTests/M5StickTestApp/M5StickTestApp.nfproj
is excluded by none and included by noneTests/M5StickTestApp/packages.config
is excluded by none and included by noneTests/ToughTestApp/ToughTestApp.nfproj
is excluded by none and included by noneTests/ToughTestApp/packages.config
is excluded by none and included by nonenanoFramework.AtomLite.nuspec
is excluded by none and included by nonenanoFramework.AtomLite/nanoFramework.AtomLite.nfproj
is excluded by none and included by nonenanoFramework.AtomLite/packages.config
is excluded by none and included by nonenanoFramework.AtomMatrix.nuspec
is excluded by none and included by nonenanoFramework.AtomMatrix/nanoFramework.AtomMatrix.nfproj
is excluded by none and included by nonenanoFramework.AtomMatrix/packages.config
is excluded by none and included by nonenanoFramework.Fire.nuspec
is excluded by none and included by nonenanoFramework.Fire/nanoFramework.Fire.nfproj
is excluded by none and included by nonenanoFramework.Fire/packages.config
is excluded by none and included by nonenanoFramework.M5Core.nuspec
is excluded by none and included by nonenanoFramework.M5Core/nanoFramework.M5Core.nfproj
is excluded by none and included by nonenanoFramework.M5Core/packages.config
is excluded by none and included by nonenanoFramework.M5Core2.nuspec
is excluded by none and included by nonenanoFramework.M5Core2/nanoFramework.M5Core2.nfproj
is excluded by none and included by nonenanoFramework.M5Core2/packages.config
is excluded by none and included by nonenanoFramework.M5StickC.nuspec
is excluded by none and included by nonenanoFramework.M5StickC/nanoFramework.M5StickC.nfproj
is excluded by none and included by nonenanoFramework.M5StickC/packages.config
is excluded by none and included by nonenanoFramework.M5StickCPlus.nuspec
is excluded by none and included by nonenanoFramework.M5StickCPlus/nanoFramework.M5StickCPlus.nfproj
is excluded by none and included by nonenanoFramework.M5StickCPlus/packages.config
is excluded by none and included by nonenanoFramework.Tough.nuspec
is excluded by none and included by nonenanoFramework.Tough/nanoFramework.Tough.nfproj
is excluded by none and included by nonenanoFramework.Tough/packages.config
is excluded by none and included by none
Files selected for processing (15)
- Tests/AtomLiteTestApp/packages.lock.json (2 hunks)
- Tests/AtomMatrixTestApp/packages.lock.json (2 hunks)
- Tests/FireTestApp/packages.lock.json (3 hunks)
- Tests/M5Core2TestApp/packages.lock.json (3 hunks)
- Tests/M5CoreTestApp/packages.lock.json (3 hunks)
- Tests/M5StickTestApp/packages.lock.json (2 hunks)
- Tests/ToughTestApp/packages.lock.json (2 hunks)
- nanoFramework.AtomLite/packages.lock.json (3 hunks)
- nanoFramework.AtomMatrix/packages.lock.json (3 hunks)
- nanoFramework.Fire/packages.lock.json (3 hunks)
- nanoFramework.M5Core/packages.lock.json (3 hunks)
- nanoFramework.M5Core2/packages.lock.json (3 hunks)
- nanoFramework.M5StickC/packages.lock.json (2 hunks)
- nanoFramework.M5StickCPlus/packages.lock.json (2 hunks)
- nanoFramework.Tough/packages.lock.json (3 hunks)
Files skipped from review due to trivial changes (6)
- Tests/AtomLiteTestApp/packages.lock.json
- Tests/AtomMatrixTestApp/packages.lock.json
- Tests/FireTestApp/packages.lock.json
- Tests/ToughTestApp/packages.lock.json
- nanoFramework.M5Core2/packages.lock.json
- nanoFramework.Tough/packages.lock.json
Additional comments not posted (33)
nanoFramework.AtomLite/packages.lock.json (3)
31-33
: Update tonanoFramework.Iot.Device.Button
version1.2.560
is correctly reflected with the appropriate content hash.
61-63
: Update tonanoFramework.System.Device.Gpio
version1.1.41
is correctly reflected with the appropriate content hash.
73-75
: Update tonanoFramework.System.Device.Spi
version1.3.52
is correctly reflected with the appropriate content hash.nanoFramework.AtomMatrix/packages.lock.json (3)
31-33
: Update tonanoFramework.Iot.Device.Button
version1.2.560
is correctly reflected with the appropriate content hash.
73-75
: Update tonanoFramework.System.Device.Gpio
version1.1.41
is correctly reflected with the appropriate content hash.
91-93
: Update tonanoFramework.System.Device.Spi
version1.3.52
is correctly reflected with the appropriate content hash.Tests/M5StickTestApp/packages.lock.json (3)
31-33
: Update tonanoFramework.Iot.Device.Axp192
version1.2.560
is correctly reflected with the appropriate content hash.
37-39
: Update tonanoFramework.Iot.Device.Button
version1.2.560
is correctly reflected with the appropriate content hash.
91-93
: Update tonanoFramework.System.Device.Gpio
version1.1.41
is correctly reflected with the appropriate content hash.nanoFramework.M5StickC/packages.lock.json (3)
31-33
: Update tonanoFramework.Iot.Device.Axp192
version1.2.560
is correctly reflected with the appropriate content hash.
37-39
: Update tonanoFramework.Iot.Device.Button
version1.2.560
is correctly reflected with the appropriate content hash.
91-93
: Update tonanoFramework.System.Device.Gpio
version1.1.41
is correctly reflected with the appropriate content hash.Tests/M5CoreTestApp/packages.lock.json (4)
19-21
: Update tonanoFramework.Iot.Device.Bmm150
version1.2.560
is correctly reflected with the appropriate content hash.
25-27
: Update tonanoFramework.Iot.Device.Button
version1.2.560
is correctly reflected with the appropriate content hash.
85-87
: Update tonanoFramework.System.Device.Gpio
version1.1.41
is correctly reflected with the appropriate content hash.
109-111
: Update tonanoFramework.System.Device.Spi
version1.3.52
is correctly reflected with the appropriate content hash.nanoFramework.M5StickCPlus/packages.lock.json (4)
31-33
: Version and content hash update fornanoFramework.Iot.Device.Axp192
are correct and consistent with the PR objectives.
37-39
: Version and content hash update fornanoFramework.Iot.Device.Button
are correct and consistent with the PR objectives.
97-99
: Version and content hash update fornanoFramework.System.Device.Gpio
are correct and consistent with the PR objectives.
97-99
: Version update fornanoFramework.System.Device.Spi
is correct and consistent with the PR objectives. Please ensure the content hash is also updated accordingly.Verification successful
The content hash for all dependencies in the
packages.lock.json
files is consistentlynull
, indicating that this might be the expected state for these files. Therefore, the absence of a non-nullcontentHash
fornanoFramework.System.Device.Spi
is not an issue.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the content hash for `nanoFramework.System.Device.Spi` is updated. # Test: Search for the content hash in the file. Expect: Updated content hash. rg --type json $'nanoFramework.System.Device.Spi'Length of output: 795
Script:
#!/bin/bash # Description: Extract and compare the content hash for `nanoFramework.System.Device.Spi` in the relevant `packages.lock.json` files. # Extract the content hash for `nanoFramework.System.Device.Spi` from each `packages.lock.json` file. for file in $(rg --files-with-matches 'nanoFramework.System.Device.Spi' --type json); do echo "File: $file" jq -r '.dependencies["nanoFramework.System.Device.Spi"].contentHash' "$file" doneLength of output: 2806
Script:
#!/bin/bash # Description: Check the presence of the `contentHash` field for other dependencies in the same `packages.lock.json` files. # Extract the content hash for other dependencies from each `packages.lock.json` file. for file in $(rg --files-with-matches 'nanoFramework.System.Device.Spi' --type json); do echo "File: $file" jq -r '.dependencies | to_entries[] | select(.key != "nanoFramework.System.Device.Spi") | .value.contentHash' "$file" doneLength of output: 3175
nanoFramework.M5Core/packages.lock.json (4)
25-27
: The version and content hash fornanoFramework.Iot.Device.Bmm150
have been updated correctly to1.2.560
.
31-33
: The version and content hash fornanoFramework.Iot.Device.Button
have been updated correctly to1.2.560
.
97-99
: The version and content hash fornanoFramework.System.Device.Gpio
have been updated correctly to1.1.41
.
121-123
: The version and content hash fornanoFramework.System.Device.Spi
have been updated correctly to1.3.52
.nanoFramework.Fire/packages.lock.json (4)
37-39
: The version and content hash fornanoFramework.Iot.Device.Bmm150
have been updated correctly to1.2.560
.
43-45
: The version and content hash fornanoFramework.Iot.Device.Button
have been updated correctly to1.2.560
.
115-117
: The version and content hash fornanoFramework.System.Device.Gpio
have been updated correctly to1.1.41
.
139-141
: The version and content hash fornanoFramework.System.Device.Spi
have been updated correctly to1.3.52
.Tests/M5Core2TestApp/packages.lock.json (5)
25-27
: The version and content hash fornanoFramework.Iot.Device.Axp192
have been updated correctly to1.2.560
.
31-33
: The version and content hash fornanoFramework.Iot.Device.Bmm150
have been updated correctly to1.2.560
.
37-39
: The version and content hash fornanoFramework.Iot.Device.Button
have been updated correctly to1.2.560
.
103-105
: The version and content hash fornanoFramework.System.Device.Gpio
have been updated correctly to1.1.41
.
127-129
: The version and content hash fornanoFramework.System.Device.Spi
have been updated correctly to1.3.52
.
"requested": "[1.1.41, 1.1.41]", | ||
"resolved": "1.1.41", | ||
"contentHash": "5QnpdfvjxOvka2S5IHSdKudWmkH+CDQ3TFFuXOGuNlgZJFsAx0/k5zuwgJYkxIyGbL8kdcjBWLyDNdihjA1pUg==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The content hash for nanoFramework.Iot.Device.Bmm150
is null
in all relevant packages.lock.json
files. This indicates a potential issue with the dependency resolution or lock file generation.
nanoFramework.M5Core2/packages.lock.json
nanoFramework.Fire/packages.lock.json
nanoFramework.M5Core/packages.lock.json
Tests/FireTestApp/packages.lock.json
Tests/M5CoreTestApp/packages.lock.json
Tests/M5Core2TestApp/packages.lock.json
Please investigate and ensure that the dependency is correctly resolved and the content hash is properly generated.
Analysis chain
Version update for nanoFramework.Iot.Device.Bmm150
is correct and consistent with the PR objectives. Please ensure the content hash is also updated accordingly.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the content hash for `nanoFramework.Iot.Device.Bmm150` is updated.
# Test: Search for the content hash in the file. Expect: Updated content hash.
rg --type json $'nanoFramework.Iot.Device.Bmm150'
Length of output: 541
Script:
#!/bin/bash
# Description: Verify the content hash for `nanoFramework.Iot.Device.Bmm150` is updated in all relevant packages.lock.json files.
# Extract and display the content hash for `nanoFramework.Iot.Device.Bmm150` in each packages.lock.json file.
for file in $(rg --files-with-matches --type json $'nanoFramework.Iot.Device.Bmm150'); do
echo "File: $file"
jq -r '.dependencies["nanoFramework.Iot.Device.Bmm150"].contentHash' "$file"
done
Length of output: 1879
Quality Gate passedIssues Measures |
Bumps nanoFramework.Iot.Device.Button from 1.2.552 to 1.2.560
Bumps nanoFramework.System.Device.Gpio from 1.1.38 to 1.1.41
Bumps nanoFramework.System.Device.Spi from 1.3.48 to 1.3.52
Bumps nanoFramework.Iot.Device.Bmm150 from 1.2.552 to 1.2.560
Bumps nanoFramework.Iot.Device.Axp192 from 1.2.548 to 1.2.560
[version update]
Summary by CodeRabbit
nanoFramework
package versions and content hashes across multiple test applications and frameworks to ensure compatibility and stability.