Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thor] Pin SFML version to SFML 2 #43016

Closed
wants to merge 1 commit into from
Closed

[thor] Pin SFML version to SFML 2 #43016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ports/thor/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,24 @@
{
"name": "thor",
"version-date": "2022-04-16",
"version-date": "2022-04-17",
"description": "Extends the multimedia library SFML with higher-level features",
"homepage": "https://bromeon.ch/libraries/thor/",
"license": "Zlib",
"dependencies": [
"aurora",
"sfml",
{
"name": "sfml",
"version>=": "2.5.0"
},
{
"name": "vcpkg-cmake",
"host": true
}
],
"overrides": [
{
"name": "sfml",
"version": "2.6.2"
}
Comment on lines +18 to +22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overrides is for top-level projects. It has no effect for ports, classic mode or vcpkg CI.

Copy link
Contributor Author

@eXpl0it3r eXpl0it3r Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does one pin dependency versions then in ports?

It shouldn't update beyond SFML 2.*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how does one update a dependency that is incompatible with other packages? Delete the other packages? Ignore them in the baseline?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update/patch as needed. Sometimes use baseline. Almost never delete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source repo has been archived. A major version update can't be patched 😄

]
}
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8933,7 +8933,7 @@
"port-version": 2
},
"thor": {
"baseline": "2022-04-16",
"baseline": "2022-04-17",
"port-version": 0
},
"thorvg": {
Expand Down
5 changes: 5 additions & 0 deletions versions/t-/thor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "c50c35f9cf935e8ca3d31a7802a2fab98b77ffe4",
"version-date": "2022-04-17",
"port-version": 0
},
{
"git-tree": "52c5298a73cdd120b4138b72dd84085cf18f53c1",
"version-date": "2022-04-16",
Expand Down