[thor] Pin SFML version to SFML 2 #43016
Conversation
eXpl0it3r
force-pushed
the
feature/thor-fix
branch
4 times, most recently
from
308f666 to
5be97fb
Compare
eXpl0it3r
force-pushed
the
feature/thor-fix
branch
from
5be97fb to
513360e
Compare
| "overrides": [ | ||
| { | ||
| "name": "sfml", | ||
| "version": "2.6.2" | ||
| } |
There was a problem hiding this comment.
overrides is for top-level projects. It has no effect for ports, classic mode or vcpkg CI.
There was a problem hiding this comment.
How does one pin dependency versions then in ports?
It shouldn't update beyond SFML 2.*
There was a problem hiding this comment.
So how does one update a dependency that is incompatible with other packages? Delete the other packages? Ignore them in the baseline?
There was a problem hiding this comment.
Update/patch as needed. Sometimes use baseline. Almost never delete.
There was a problem hiding this comment.
The source repo has been archived. A major version update can't be patched 😄
|
@BillyONeal do we just delete this package given that Thor has been archived and won't get an SFML 3 update? |
This port: * Blocks updating SFML to version 3 * Has been archived upstream since April 2022 * Is unpopular Replaces microsoft#43016
|
Closed as duplicate of #43067. |
./vcpkg x-add-version --alland committing the result.Thor has been archived and won't be receiving any updates, as such the SFML version should be pinned to >=2.5
This is currently causing issues when trying to update SFML to SFML 3, see #42913
To be honest I don't know if I understood the versioning pinning correctly, so feel free to leave any review comments.