Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CLUSTER PUBSUB #866

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

vazois
Copy link
Contributor

@vazois vazois commented Dec 9, 2024

This PR adds support for PUBSUB in Cluster mode.

  • Implement SPUBLISH and SSUBSCRIBE APIs
  • Add published message forwarding using the active gossip connections
  • Expose parameters to allow configuring max outstanding PubSub forwarding tasks
  • Augment latency and throughput benchmarks with PUBLISH and SPUBLISH support.

@vazois vazois force-pushed the vazois/cluster-pubsub branch 4 times, most recently from 2f789f5 to 422532b Compare December 12, 2024 01:28
@vazois vazois force-pushed the vazois/cluster-pubsub branch 9 times, most recently from 381fb96 to cd57d5a Compare January 13, 2025 18:44
@vazois vazois marked this pull request as ready for review January 13, 2025 19:06
@badrishc
Copy link
Contributor

Why was the BDN removed as it seemed useful?

@vazois
Copy link
Contributor Author

vazois commented Jan 14, 2025

Why was the BDN removed as it seemed useful?

Because it was not related to cluster. It was only exercising the publish path with no connected nodes. I am not sure how communication over socket will affect BDN.

@vazois vazois force-pushed the vazois/cluster-pubsub branch from ffd61b3 to f1938bf Compare January 14, 2025 18:30
@vazois vazois force-pushed the vazois/cluster-pubsub branch from f1938bf to 74325aa Compare January 17, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants