remove option for tasks

microsoft · Jan 13, 2025 · cd57d5a · cd57d5a
1 parent ee15c4d
commit cd57d5a
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 14 deletions.
diff --git a/libs/cluster/Server/GarnetServerNode.cs b/libs/cluster/Server/GarnetServerNode.cs
@@ -92,7 +92,7 @@ public GarnetServerNode(ClusterProvider clusterProvider, string address, int por
             this.gc = new GarnetClient(
                 address, port, tlsOptions,
                 sendPageSize: opts.DisablePubSub ? defaultSendPageSize : Math.Max(defaultSendPageSize, (int)opts.PubSubPageSizeBytes()),
-                maxOutstandingTasks: opts.DisablePubSub ? defaultMaxOutstandingTask : Math.Max(defaultMaxOutstandingTask, opts.MaxPubSubTasks),
+                maxOutstandingTasks: defaultMaxOutstandingTask,
                 timeoutMilliseconds: opts.ClusterTimeout <= 0 ? 0 : TimeSpan.FromSeconds(opts.ClusterTimeout).Milliseconds,
                 authUsername: clusterProvider.clusterManager.clusterProvider.ClusterUsername,
                 authPassword: clusterProvider.clusterManager.clusterProvider.ClusterPassword,

diff --git a/libs/host/Configuration/Options.cs b/libs/host/Configuration/Options.cs
@@ -155,10 +155,6 @@ internal sealed class Options
         [Option("pubsub-pagesize", Required = false, HelpText = "Page size of log used for pub/sub (rounds down to power of 2)")]
         public string PubSubPageSize { get; set; }
 
-        [IntRangeValidation(0, int.MaxValue)]
-        [Option("max-pubsub-tasks", Required = false, HelpText = "Number of outstanding forwarding pubsub tasks at any given time")]
-        public int MaxPubSubTasks { get; set; }
-
         [OptionValidation]
         [Option("no-obj", Required = false, HelpText = "Disable support for data structure objects.")]
         public bool? DisableObjects { get; set; }
@@ -650,7 +646,6 @@ public GarnetServerOptions GetServerOptions(ILogger logger = null)
                 EnableIncrementalSnapshots = EnableIncrementalSnapshots.GetValueOrDefault(),
                 DisablePubSub = DisablePubSub.GetValueOrDefault(),
                 PubSubPageSize = PubSubPageSize,
-                MaxPubSubTasks = MaxPubSubTasks,
                 DisableObjects = DisableObjects.GetValueOrDefault(),
                 EnableCluster = EnableCluster.GetValueOrDefault(),
                 CleanClusterConfig = CleanClusterConfig.GetValueOrDefault(),

diff --git a/libs/host/defaults.conf b/libs/host/defaults.conf
@@ -96,9 +96,6 @@
 	/* Page size of log used for pub/sub (rounds down to power of 2) */
 	"PubSubPageSize" : "4k",
 
-	/* Number of outstanding forwarding pubsub tasks at any given time */
-	"MaxPubSubTasks" : "1024",
-
 	/* Disable support for data structure objects. */
 	"DisableObjects" : false,
 

diff --git a/libs/server/Servers/ServerOptions.cs b/libs/server/Servers/ServerOptions.cs
@@ -93,11 +93,6 @@ public class ServerOptions
         /// </summary>
         public string PubSubPageSize = "4k";
 
-        /// <summary>
-        /// Number of outstanding forwarding pubsub tasks at any given time
-        /// </summary>
-        public int MaxPubSubTasks = 1 << 10;
-
         /// <summary>
         /// Server bootup should fail if errors happen during bootup of AOF and checkpointing.
         /// </summary>