Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: Visual diffs for ISO 8601 Amendment 1 layout #1251

Open
manuelfuenmayor opened this issue Dec 3, 2024 · 7 comments
Open

PDF: Visual diffs for ISO 8601 Amendment 1 layout #1251

manuelfuenmayor opened this issue Dec 3, 2024 · 7 comments

Comments

@manuelfuenmayor
Copy link

As requested in https://github.com/CalConnect/iso-8601-2-amd1/issues/20#issuecomment-2513141735

Following is a list of visual differences of generated PDF of ISO 8601 Amendment 1 against its original version.
(I think some parts should be addressed via markup, where indicated.)

  1. In front page, document identification is shown different.

    Generated:

    Original:

  2. In front page, original document, title in French is not shown. (This is markup addressable.)

    Generated:

    Original:

  3. In front page, vertical space between text "PROOF/ÉPREUVE" and reference number is less in original version compared to generated. Also, the format of the reference number is different.

    Generated:

    Original:

  4. The text "PROOF/ÉPREUVE" at the bottom area of every page is missing in generated version.

    Generated:

    Original:

  5. In section 3.1.2, the format of the section titles is different. (I think this must be addressed by markup, but I'm not sure how.)

    Generated:

    Original:

  6. In section 14.7, subsection titles are bold in original version, and italic in generated version.

    Generated:

    Original:

@Intelligent2013
Copy link
Contributor

  1. In front page, document identification is shown different.

ISO XSLT renders the docidentifier from <docidentifier type="iso-undated", but this element is missing in the Presentation XML. If iso-undated is missing, the XSLT uses the full docidentifier type="ISO".
This issue relates to the issue #1246 (comment).

Edition date rendering added in ISO XSLT, but revision date should be changed to :revdate: 2019-02-01 (01 just to fit the date format, may be need to set the real day).

  1. In front page, original document, title in French is not shown. (This is markup addressable.)

ISO XSLT updated to hide the French title for the 'proof' stage.

  1. In front page, vertical space between text "PROOF/ÉPREUVE" and reference number is less in original version compared to generated.

Updated in ISO XSLT.

  1. The text "PROOF/ÉPREUVE" at the bottom area of every page is missing in generated version.

Updated in ISO XSLT.

@manuelfuenmayor
Copy link
Author

manuelfuenmayor commented Dec 9, 2024

ISO XSLT renders the docidentifier from <docidentifier type="iso-undated", but this element is missing in the Presentation XML. If iso-undated is missing, the XSLT uses the full docidentifier type="ISO".

@Intelligent2013 if I set :docidentifier: ISO 8601-2 to fix the issue. The "Reference number" at the bottom of the from page, disappears:

@Intelligent2013
Copy link
Contributor

There are differences in the Presentation XML.
Left pane - added :docidentifier: ISO 8601-2, right pane - without :docidentifier: ISO 8601-2
image

<docidentifier type="iso-reference"> is using for rendering the item under the "Reference number" at the bottom.

This issue relates to #1246 (comment).

@ronaldtse
Copy link
Contributor

@Intelligent2013 there are a few things we should not fix:

  1. Hiding french title. We do not want to hide the French title. This is likely ISO's mistake.
  2. "In section 3.1.2, the format of the section titles is different" This is a syntax inadequacy we have in Metanorma for encoding Amendments. This is not a rendering issue. @manuelfuenmayor please file an issue on this.
  3. "the format of the reference number is different." The "ISO 8601-2:2019/Amd.1:2024" you see in the ISO PDF is wrong. The proper stage is called "Amd 1", not "Amd.1". ISO is wrong
  4. The docidentifier given at the PRF stage is twofold. A PRF document mimics the published document, so it uses the published document's reference number. However, it itself is referenced by the PRF identifier. The XSLT should not mess with the reference number but use what is given in the XML. If the XML is insufficient, we fix that instead.

@Intelligent2013
Copy link
Contributor

  1. Hiding french title. We do not want to hide the French title. This is likely ISO's mistake.

ISO XSLT restored.

  1. The docidentifier given at the PRF stage is twofold. A PRF document mimics the published document, so it uses the published document's reference number. However, it itself is referenced by the PRF identifier. The XSLT should not mess with the reference number but use what is given in the XML. If the XML is insufficient, we fix that instead.

I've added the fallback for this case, see #1246 (comment).

@manuelfuenmayor
Copy link
Author

"In section 3.1.2, the format of the section titles is different" This is a syntax inadequacy we have in Metanorma for encoding Amendments. This is not a rendering issue. @manuelfuenmayor please file an issue on this.

Done

@ronaldtse
Copy link
Contributor

Thank you @manuelfuenmayor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants