Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF: ISO 2024 layout validation for Amendments #1250

Open
ronaldtse opened this issue Dec 1, 2024 · 6 comments
Open

PDF: ISO 2024 layout validation for Amendments #1250

ronaldtse opened this issue Dec 1, 2024 · 6 comments
Assignees

Comments

@ronaldtse
Copy link
Contributor

PDF diffs of the ISO 8601-1:2019/PRF Amd 1 between ISO and our version.

@manuelfuenmayor will provide the diffs, with the PDFs available in a private issue.

@ronaldtse
Copy link
Contributor Author

The issue with the PDFs is this:

@Intelligent2013
Copy link
Contributor

The issue with the PDFs is this:

@ronaldtse GH outputs the Error 404 for me. Could you add me to the repo rights, please?

@ronaldtse
Copy link
Contributor Author

@Intelligent2013 you have access now. Thanks!

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Dec 4, 2024

@Intelligent2013 you have access now. Thanks!

@ronaldtse thank you!

Need update of XSLT for PDF based on differences in #1251:

  • if stage is 60, and substage is 00, then logo and doc identifier color should be black, instead of red (currently, red is using if stage is 60)
  • docidentifier is just ISO 8601-2 instead of full ISO 8601-2:2019/PRF Amd 1:2024, because edition number and amendment number render below, UPDATE see comment PDF: ISO 2024 layout validation for Amendments #1250 (comment)
  • no need to render French title if substage is 00
  • move PROOF/ÉPREUVE below and increase font size to 34pt
  • render PROOF/ÉPREUVE in the footer

@Intelligent2013
Copy link
Contributor

docidentifier is just ISO 8601-2 instead of full ISO 8601-2:2019/PRF Amd 1:2024

ISO XSLT renders the docidentifier from <docidentifier type="iso-undated", but this element is missing in the Presentation XML. If iso-undated is missing, the XSLT uses the full docidentifier type="ISO".
This issue relates to the issue #1246 (comment).

Intelligent2013 added a commit to metanorma/mn-native-pdf that referenced this issue Dec 4, 2024
@Intelligent2013
Copy link
Contributor

ISO XSLT updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Status: 🆕 New
Development

No branches or pull requests

3 participants