Scheduling revamp #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 13, 2025 01:04
Muxianesty
added
enhancement
added 5 commits
January 13, 2025 04:26
…ling now recognizes constant input operations.
…tencyConfig-objects were added; tests were updated according to new features.
ssmolov
reviewed
Jan 17, 2025
Comment on lines
202
to
205
| if (bool(noQuestion) == bool(noAttr)) { | ||
| return parser.emitError(latencyLoc) << "'" << result.name.getStringRef() << | ||
| "' op requires either '?' or valid latency specified"; | ||
| } |
Comment on lines
220
to
225
| parser.parseColon() || | ||
| parser.parseCustomTypeWithFallback(firstRawTypes[0]) || | ||
| parser.parseRParen() || | ||
| parser.parseColon() || | ||
| parser.parseCustomTypeWithFallback(resRawTypes[0]) || | ||
| parser.parseOptionalAttrDict(result.attributes)) { |
Comment on lines
311
to
314
| if (bool(noQuestion) == bool(noAttr)) { | ||
| return parser.emitError(latencyLoc) << "'" << result.name.getStringRef() << | ||
| "' op requires either '?' or valid latency specified"; | ||
| } |
There was a problem hiding this comment.
Bad indent.
Also looks like copy-paste of 197-205 lines
There was a problem hiding this comment.
Fixed indent. Corresponding function instead of copy-paste will be added later in this MR.
Comment on lines
336
to
341
| if (parser.parseOperand(secondRawOperands[0]) || | ||
| parser.parseColon() || | ||
| parser.parseCustomTypeWithFallback(secondRawTypes[0]) || | ||
| parser.parseRParen() || | ||
| parser.parseColon() || | ||
| parser.parseCustomTypeWithFallback(resRawTypes[0]) || |
There was a problem hiding this comment.
Bad indent.
Also looks similar to complex expression from 219-224 lines. Can we not to copy-paste them?
There was a problem hiding this comment.
Fixed indent. Corresponding function instead of copy-paste will be added later in this MR.
| // | ||
| // Part of the Utopia HLS Project, under the Apache License v2.0 | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // Copyright 2024 ISP RAS (http://www.ispras.ru) |
| Graph::Graph(ModuleOp module) | ||
| : Graph(mlir::utils::findFirstOccurence<KernelOp>(module)) {} | ||
|
|
||
|
|
| return (isFloat) ? Ops::NEQ_FLOAT : Ops::NEQ_INT; | ||
| } | ||
|
|
||
| assert(false && "Shouldn't reach this"); |
There was a problem hiding this comment.
Non-informative; can we print useful information about op here?
ssmolov
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Merge Request introduces the following changes:
dfcir.latencyoperation added;%0 = dfcir.add[2] (...), which means 2 pipeline stages for addition, and%0 = dfcir.add[?] (...)if the operation wasn't scheduled yet);--out-scheduled-dfcir <PATH>option was introduced.Remaining tasks:
dfcir.constanddfcir.scalarInputrecognition in scheduling;dfcir.offsetdeletion after scheduling;docs/latency_config.md.