Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: specify proceedings in imprint title label #1923

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

contrib: specify proceedings in imprint title label #1923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions invenio_rdm_records/contrib/imprint/custom_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# -*- coding: utf-8 -*-
#
# Copyright (C) 2023 CERN.
# Copyright (C) 2023-2025 CERN.
#
# Invenio-RDM-Records is free software; you can redistribute it and/or modify
# it under the terms of the MIT License; see LICENSE file for more details.
Expand Down Expand Up @@ -73,7 +73,9 @@ def mapping(self):
"ui_widget": "Imprint",
"template": "imprint.html",
"props": {
"label": _("Imprint (Book, Chapter, or Report)"),
"label": _(
"Imprint (Book, Chapter, Report, or Conference proceedings)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably switch to "Imprint (Book, Report, or Conference proceedings)"

),
"place": {
"label": _("Place"),
"placeholder": _("e.g. city, country"),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field (Place) has a description matching the "book or report" (Place where the book or report was published), so I'm wondering if it should be changed too for consistency.
However, this field is not used in the BibTex export.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're for leaving it as-is. We want to encourage folks to use the conference place field for location, so adding conference-related help text here is likely to cause more confusion.

Expand All @@ -85,10 +87,10 @@ def mapping(self):
"description": _("International Standard Book Number"),
},
"title": {
"label": _("Book or report title"),
"label": _("Book, report title, or proceedings"),
"placeholder": "",
"description": _(
"Title of the book or report which this upload is part of"
"Title of the book, report, or proceedings which this upload is part of"
),
},
"pages": {
Expand Down
Loading