-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib: specify proceedings in imprint title label #1923
base: master
Are you sure you want to change the base?
contrib: specify proceedings in imprint title label #1923
Conversation
@@ -73,7 +73,7 @@ def mapping(self): | |||
"ui_widget": "Imprint", | |||
"template": "imprint.html", | |||
"props": { | |||
"label": _("Imprint (Book, Chapter, or Report)"), | |||
"label": _("Imprint (Book, Chapter, Report, or Conference proceedings)"), | |||
"place": { | |||
"label": _("Place"), | |||
"placeholder": _("e.g. city, country"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field (Place
) has a description matching the "book or report" (Place where the book or report was published
), so I'm wondering if it should be changed too for consistency.
However, this field is not used in the BibTex export.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're for leaving it as-is. We want to encourage folks to use the conference place field for location, so adding conference-related help text here is likely to cause more confusion.
83eb674
to
0e94994
Compare
The Caltech library folks reviewed this change, and it looks good. We also think it might be good to remove Chapter. Caltech added it in the first place, so we're fixing our own mistake. With the new book section serializer #1921, the fields are specific not about the Chapter, they are about the Book. So "Imprint (Book, Report, or Conference proceedings)" is probably an even better label. |
@@ -73,7 +73,9 @@ def mapping(self): | |||
"ui_widget": "Imprint", | |||
"template": "imprint.html", | |||
"props": { | |||
"label": _("Imprint (Book, Chapter, or Report)"), | |||
"label": _( | |||
"Imprint (Book, Chapter, Report, or Conference proceedings)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably switch to "Imprint (Book, Report, or Conference proceedings)"
@@ -73,7 +73,7 @@ def mapping(self): | |||
"ui_widget": "Imprint", | |||
"template": "imprint.html", | |||
"props": { | |||
"label": _("Imprint (Book, Chapter, or Report)"), | |||
"label": _("Imprint (Book, Chapter, Report, or Conference proceedings)"), | |||
"place": { | |||
"label": _("Place"), | |||
"placeholder": _("e.g. city, country"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're for leaving it as-is. We want to encourage folks to use the conference place field for location, so adding conference-related help text here is likely to cause more confusion.
❤️ Thank you for your contribution!
Description
booktitle
BibTeX field #1919Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: