This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 19, 2020
cpanato
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for more reviews
k8s-ci-robot
added
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
lgtm
Indicates that a PR is ready to be merged.
labels
Oct 19, 2020
unguiculus
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🎉
helm-bot
added
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Oct 19, 2020
Signed-off-by: Scott Rigby <[email protected]>
Signed-off-by: Scott Rigby <[email protected]>
Signed-off-by: Scott Rigby <[email protected]>
scottrigby
force-pushed
the
chart-repo-gh-pages
branch
from
October 19, 2020 15:01
8c45606
to
1600ee0
Compare
/lgtm |
paulczar
approved these changes
Oct 19, 2020
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 19, 2020
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, paulczar, scottrigby, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
Contribution Allowed
If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO).
lgtm
Indicates that a PR is ready to be merged.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #23850 (explanatory blog post forthcoming).
See https://github.com/scottrigby/chart-repo-gh-pages for a vanilla working example.
Notes:
test/repo-sync.sh
, since for now we want to continue publishing both to GCR and gh-pages. @viglesiasce this is where our timeline/plan comes in. Can be addressed in follow-up PRs.run
steps could be moved into local actions, but it didn't seem as though it would help much here, and I hope the shell is clear all in one place.