-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gh-pages Readme #1335
Add gh-pages Readme #1335
Conversation
Depends on kubernetes/test-infra#20291 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/restest |
force pushing to trigger re-checking if the configs from kubernetes/test-infra#20291 have propagated |
7841f06
to
d6ade48
Compare
tests will run only for |
👍 we don't want actions to run on the |
Signed-off-by: Scott Rigby <[email protected]>
d6ade48
to
64a407b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
kubernetes/test-infra#20426 appears to have worked 👍 tide just needs |
/assign @tariq1890 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cpanato, mrueg, scottrigby, tariq1890 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cpanato @scottrigby do we need to add an OWNERS file on the gh-pages branch or is that something that needs to be fixed on test-infra side? |
@mrueg That's a good question. I think that depends on how we want to handle this. A repo admin should now be able to merge this PR to the gh-pages branch directly, without prow. If we want to use prow for direct merges to gh-pages (for PRs like this, which aren't automated from PRs to master), I think you may be right about an OWNERS file. Let's try to get this right. I'll open a question in k8s slack #github-management now. |
Slack convo started: https://kubernetes.slack.com/archives/C01672LSZL0/p1610380054131300 I'm giving a talk today, so I may have to circle back to this later in the day. |
@scottrigby Thanks for this PR. I am okay with manually merging this as a one-off right now, but I think it's better to incorporate as much automation as we can to this branch as well. |
@tariq1890 re automation I had set up README sync github action here https://github.com/prometheus-community/helm-charts/blob/main/.github/workflows/sync-readme.yaml and here helm/charts#23921, both of which have worked well. I didn't do that for this repo but could do in a follow-up PR. |
What this PR does / why we need it:
Friendly landing page for end users who may browse to https://kubernetes.github.io/kube-state-metrics.
Once merged, it would look similar to https://prometheus-community.github.io/helm-charts/