Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gh-pages Readme #1335

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Conversation

scottrigby
Copy link
Contributor

What this PR does / why we need it:

Friendly landing page for end users who may browse to https://kubernetes.github.io/kube-state-metrics.

Once merged, it would look similar to https://prometheus-community.github.io/helm-charts/

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2020
@scottrigby
Copy link
Contributor Author

Depends on kubernetes/test-infra#20291

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scottrigby
Copy link
Contributor Author

/restest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2020
@scottrigby
Copy link
Contributor Author

force pushing to trigger re-checking if the configs from kubernetes/test-infra#20291 have propagated

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2020
@cpanato
Copy link
Member

cpanato commented Dec 22, 2020

tests will run only for master and release branches
https://github.com/kubernetes/kube-state-metrics/blob/master/.github/workflows/ci.yml#L13

@scottrigby
Copy link
Contributor Author

👍 we don't want actions to run on the gh-pages branch. For future ref, what I was testing by re-pushing is whether those checks were still configured as Required. They appear to be (screenshot below). Opened a follow-up PR in test-infra to remove them: kubernetes/test-infra#20322

Screen Shot 2020-12-22 at 12 30 56 PM

Signed-off-by: Scott Rigby <[email protected]>
Copy link
Contributor

@tariq1890 tariq1890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@scottrigby
Copy link
Contributor Author

kubernetes/test-infra#20426 appears to have worked 👍
Screen Shot 2021-01-10 at 2 48 40 PM

tide just needs approved, lgtm labels again, then we should be good to go.

@scottrigby
Copy link
Contributor Author

/assign @tariq1890

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2021
@mrueg
Copy link
Member

mrueg commented Jan 11, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato, mrueg, scottrigby, tariq1890
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrueg
Copy link
Member

mrueg commented Jan 11, 2021

@cpanato @scottrigby do we need to add an OWNERS file on the gh-pages branch or is that something that needs to be fixed on test-infra side?

@scottrigby
Copy link
Contributor Author

@mrueg That's a good question. I think that depends on how we want to handle this. A repo admin should now be able to merge this PR to the gh-pages branch directly, without prow. If we want to use prow for direct merges to gh-pages (for PRs like this, which aren't automated from PRs to master), I think you may be right about an OWNERS file. Let's try to get this right. I'll open a question in k8s slack #github-management now.

@scottrigby
Copy link
Contributor Author

Slack convo started: https://kubernetes.slack.com/archives/C01672LSZL0/p1610380054131300 I'm giving a talk today, so I may have to circle back to this later in the day.

@tariq1890
Copy link
Contributor

@scottrigby Thanks for this PR.

I am okay with manually merging this as a one-off right now, but I think it's better to incorporate as much automation as we can to this branch as well.

@tariq1890 tariq1890 merged commit 6dc1036 into kubernetes:gh-pages Jan 13, 2021
@scottrigby
Copy link
Contributor Author

@tariq1890 re automation I had set up README sync github action here https://github.com/prometheus-community/helm-charts/blob/main/.github/workflows/sync-readme.yaml and here helm/charts#23921, both of which have worked well. I didn't do that for this repo but could do in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants