Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dragging entry values into page input fields (without copying to clipboard) #216

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Allow dragging entry values into page input fields (without copying to clipboard) #216

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ab0d74
draggable email, otp token
Mar 24, 2022
9058a85
cleanup
Mar 24, 2022
f0d27ff
cleanup
Mar 24, 2022
f1e62d5
revert urlDomain(), fix _onSearchInputEvent for ff
Mar 24, 2022
eb55d9b
Merge branch 'master' into dragme
martinhoefling Apr 8, 2022
eddb1d1
Merge branch 'master' into dragme
glowinthedark Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion web-extension/details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,11 @@ function _createURLValueElement(value) {

function _createSimpleValueElement(value) {
const valueElement = document.createElement('span');
valueElement.innerText = value;
valueElement.innerHTML = `<span class="gripper"></span>${value}`;
valueElement.addEventListener('click', _copyElementToClipboard);
valueElement.addEventListener('dragstart', function (e) {
e.dataTransfer.setData('text', value);
});
return valueElement;
}

Expand All @@ -80,6 +83,7 @@ function _isURL(value) {
function _createFlatValueElement(value) {
const valueElement = _isURL(value) ? _createURLValueElement(value) : _createSimpleValueElement(value);
valueElement.classList.add('detail-clickable-value');
valueElement.setAttribute('draggable', 'true');
return valueElement;
}

Expand Down
12 changes: 9 additions & 3 deletions web-extension/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ function initSearch() {

setTimeout(() => {
input.focus();
_onSearchInputEvent();
}, 200);
}

Expand All @@ -28,8 +29,13 @@ function _onSearchInputEvent() {
if (input.value.length) {
search(input.value);
} else {
const currentHost = urlDomain(currentPageUrl);
searchHost(currentHost);
// covers both chrome and ff
browser.tabs.query({ currentWindow: true, active: true }).then((tabs) => {
const url = new URL(tabs[0].url);
const host = url.host;
document.getElementById('search_input').value = host;
searchHost(host);
}, console.error);
}
}

Expand Down Expand Up @@ -84,7 +90,7 @@ function search(term) {

function searchHost(host) {
browser.storage.local.remove(LAST_DOMAIN_SEARCH_PREFIX + host);
document.getElementById('search_input').value = '';
// document.getElementById('search_input').value = '';

console.log('Searching for host ' + host);
return _doSearch(host, true);
Expand Down
51 changes: 46 additions & 5 deletions web-extension/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,38 @@ body {
}

.detail-clickable-value:hover {
background: rgba(96, 109, 197, 0.41);
background: rgba(245, 167, 0, 0.548);
}

.detail-clickable-value:active {
background-color: rgba(0, 0, 0, 0.1);
background-color: rgba(252, 133, 22, 0.1);
}

.gripper {
content: '....';
width: 10px;
height: 20px;
display: inline-block;
overflow: hidden;
line-height: 5px;
padding: 3px 4px;
cursor: move;
vertical-align: middle;
margin-top: -0.7em;
margin-right: 0.3em;
font-size: 12px;
font-family: sans-serif;
letter-spacing: 2px;
color: #cccccc;
text-shadow: 1px 0 1px black;
}
.gripper::after {
content: '.. .. .. ..';
}

.entry {
position: relative;
background-color: #f8f8f8;
}

.detail-view {
Expand All @@ -68,12 +91,23 @@ body {
-moz-appearance: none;
border: 0;
width: 100%;
padding: 10px 7px 10px 32px;
padding: 10px 7px;
border-bottom: 1px dotted #6bd6e4;
text-align: left;
line-height: 1.2;
font-size: 12px;
font-size: 14px;
min-height: 32px;
list-style-type: none;
}

.detail-view li {
padding: 0.7em 0;
color: gray;
}

.detail-view .detail-key,
.detail-view .detail-clickable-value {
display: block;
}

.detail-key {
Expand All @@ -82,7 +116,14 @@ body {
}

.detail-clickable-value {
cursor: pointer;
cursor: move;
border: solid 1px #ccc;
padding: 1em;
transition: box-shadow 200ms cubic-bezier(0, 0, 0.2, 1);
box-shadow: 0 3px 1px -2px rgba(0, 0, 0, 0.2), 0 2px 2px 0 rgba(0, 0, 0, 0.14), 0 1px 5px 0 rgba(0, 0, 0, 0.12);
background: #fff;
border-radius: 4px;
-webkit-user-drag: element;
}

.detail-nested {
Expand Down