Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dragging entry values into page input fields (without copying to clipboard) #216

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

glowinthedark
Copy link

A POC allowing dragging items from the entry into input fields on the page. Only tested on Chrome, possibly further adjustments might be needed for firefox.

Please provide your comments as to what can be improved.

@glowinthedark glowinthedark changed the title Allow dragging entry values into the page input fields (without copying to clipboard) Allow dragging entry values into page input fields (without copying to clipboard) Mar 24, 2022
Copy link
Collaborator

@martinhoefling martinhoefling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a first look. We definitely need to check if we should add tests as well as removal of the code commented out. @Pharb do you have more experience with drag and drop and what needs to be considered?

@glowinthedark
Copy link
Author

glowinthedark commented Apr 9, 2022

@martinhoefling: the changes in search.js are in fact addressing another issue — the domain name is not getting pre-filled in either chrome or firefox.

Do you think it would be better to revert those changes so that the issue can be solved in its own separate thread? The approach I followed might not be the best, and in fact causes a possibly annoying artifact — after manually clearing the input field the domain gets pre-filled again because I added a call to _onSearchInputEvent(); inside initSearch(). Please advise.

Another issue I was trying to figure out is how to get the actual password and include a draggable password field displayed as ******** into the details view div. Imo, it would be nice to be able to drag the password too without copying it to clipboard — this way it's a bit more secure. But not clear how to do it since I have zero experience with chrome extensions api and native hosts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants