-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update golang/x/net to 0.33.0 #5639
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,44 @@ | ||
| module github.com/googleapis/repo-automation-bots/packages/flakybot | ||
|
|
||
| go 1.19 | ||
| go 1.23.2 | ||
|
|
||
| require ( | ||
| cloud.google.com/go/pubsub v1.30.0 | ||
| github.com/google/go-cmp v0.5.9 | ||
| google.golang.org/api v0.114.0 | ||
| cloud.google.com/go/pubsub v1.45.3 | ||
| github.com/google/go-cmp v0.6.0 | ||
| google.golang.org/api v0.213.0 | ||
| ) | ||
|
|
||
| require ( | ||
| cloud.google.com/go v0.110.0 // indirect | ||
| cloud.google.com/go/compute v1.19.1 // indirect | ||
| cloud.google.com/go/compute/metadata v0.2.3 // indirect | ||
| cloud.google.com/go/iam v0.13.0 // indirect | ||
| github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect | ||
| github.com/golang/protobuf v1.5.3 // indirect | ||
| github.com/googleapis/enterprise-certificate-proxy v0.2.3 // indirect | ||
| github.com/googleapis/gax-go/v2 v2.7.1 // indirect | ||
| cloud.google.com/go v0.117.0 // indirect | ||
| cloud.google.com/go/auth v0.13.0 // indirect | ||
| cloud.google.com/go/auth/oauth2adapt v0.2.6 // indirect | ||
| cloud.google.com/go/compute/metadata v0.6.0 // indirect | ||
| cloud.google.com/go/iam v1.3.0 // indirect | ||
| github.com/felixge/httpsnoop v1.0.4 // indirect | ||
| github.com/go-logr/logr v1.4.2 // indirect | ||
| github.com/go-logr/stdr v1.2.2 // indirect | ||
| github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 // indirect | ||
| github.com/google/s2a-go v0.1.8 // indirect | ||
| github.com/google/uuid v1.6.0 // indirect | ||
| github.com/googleapis/enterprise-certificate-proxy v0.3.4 // indirect | ||
| github.com/googleapis/gax-go/v2 v2.14.0 // indirect | ||
| go.opencensus.io v0.24.0 // indirect | ||
| golang.org/x/net v0.23.0 // indirect | ||
| golang.org/x/oauth2 v0.7.0 // indirect | ||
| golang.org/x/sync v0.1.0 // indirect | ||
| golang.org/x/sys v0.18.0 // indirect | ||
| golang.org/x/text v0.14.0 // indirect | ||
| google.golang.org/appengine v1.6.7 // indirect | ||
| google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 // indirect | ||
| google.golang.org/grpc v1.56.3 // indirect | ||
| google.golang.org/protobuf v1.33.0 // indirect | ||
| go.opentelemetry.io/auto/sdk v1.1.0 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.58.0 // indirect | ||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.58.0 // indirect | ||
| go.opentelemetry.io/otel v1.33.0 // indirect | ||
| go.opentelemetry.io/otel/metric v1.33.0 // indirect | ||
| go.opentelemetry.io/otel/trace v1.33.0 // indirect | ||
| golang.org/x/crypto v0.31.0 // indirect | ||
| golang.org/x/net v0.33.0 // indirect | ||
| golang.org/x/oauth2 v0.24.0 // indirect | ||
| golang.org/x/sync v0.10.0 // indirect | ||
| golang.org/x/sys v0.28.0 // indirect | ||
| golang.org/x/text v0.21.0 // indirect | ||
| golang.org/x/time v0.8.0 // indirect | ||
| google.golang.org/genproto v0.0.0-20241219192143-6b3ec007d9bb // indirect | ||
| google.golang.org/genproto/googleapis/api v0.0.0-20241219192143-6b3ec007d9bb // indirect | ||
| google.golang.org/genproto/googleapis/rpc v0.0.0-20241219192143-6b3ec007d9bb // indirect | ||
| google.golang.org/grpc v1.69.2 // indirect | ||
| google.golang.org/protobuf v1.36.0 // indirect | ||
| ) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this bot is built but note this is bumping the min version of Go to 1.23.2. Do we need to update a docker file to? I personally never use the -u flag as it literally bumps everything include all indirect deps. Usually I would just
go get some/dep@latest && go mod tidy.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already using go 1.23 in the Dockerfile (https://github.com/googleapis/repo-automation-bots/blob/1aab308d37bda94e51e08956915af3be465f4453/serverless-scheduler-proxy/Dockerfile)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will monitor the app and be ready to revert if it breaks