fix(deps): update golang/x/net to 0.33.0 #5639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
approved these changes
Dec 20, 2024
| @@ -1,30 +1,44 @@ | |||
| module github.com/googleapis/repo-automation-bots/packages/flakybot | |||
|
|
|||
| go 1.19 | |||
| go 1.23.2 | |||
There was a problem hiding this comment.
Not sure how this bot is built but note this is bumping the min version of Go to 1.23.2. Do we need to update a docker file to? I personally never use the -u flag as it literally bumps everything include all indirect deps. Usually I would just go get some/dep@latest && go mod tidy.
There was a problem hiding this comment.
This is already using go 1.23 in the Dockerfile (https://github.com/googleapis/repo-automation-bots/blob/1aab308d37bda94e51e08956915af3be465f4453/serverless-scheduler-proxy/Dockerfile)
There was a problem hiding this comment.
We will monitor the app and be ready to revert if it breaks
meltsufin
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran: