Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make git clone URL could use current signed-in user #33091

Merged
merged 11 commits into from
Jan 7, 2025
Merged

Make git clone URL could use current signed-in user #33091

merged 11 commits into from
Jan 7, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 3, 2025 •
edited
Loading

close #33086

  • Add a special value for "SSH_USER" setting: (DOER_USERNAME)
  • Improve parseRepositoryURL and add tests (now it doesn't have hard dependency on some setting values)

Many changes are just adding "ctx" and "doer" argument to functions.

By the way, improve app.example.ini, remove all %(key)s syntax, it only makes messy and no user really cares about it.

Document: https://gitea.com/gitea/docs/pulls/138

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 3, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 3, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/migrations docs-update-needed The document needs to be updated synchronously labels Jan 3, 2025
@wxiaoguang wxiaoguang changed the title fix Make git clone URL could use current signed-in user Jan 3, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 3, 2025
Closed
@wxiaoguang wxiaoguang force-pushed the fix-ssh-user branch 3 times, most recently from 4cd7d59 to 85782b3 Compare January 3, 2025 04:14
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Jan 3, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 3, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Jan 3, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 4, 2025
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 4, 2025
@wxiaoguang wxiaoguang requested a review from Zettat123 January 6, 2025 04:14
@wxiaoguang wxiaoguang requested a review from bohde January 7, 2025 00:35
Zettat123
Zettat123 approved these changes Jan 7, 2025
View reviewed changes
models/repo/repo.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 7, 2025
wxiaoguang
wxiaoguang commented Jan 7, 2025
View reviewed changes
custom/conf/app.example.ini Outdated Show resolved Hide resolved
custom/conf/app.example.ini Outdated Show resolved Hide resolved
custom/conf/app.example.ini Outdated Show resolved Hide resolved
custom/conf/app.example.ini Outdated Show resolved Hide resolved
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 7, 2025
@lunny lunny merged commit 34dfc25 into go-gitea:main Jan 7, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 7, 2025
@wxiaoguang wxiaoguang deleted the fix-ssh-user branch January 7, 2025 05:42
@prologic
Copy link

prologic commented Jan 7, 2025

Very nice! 👌 Thank you so much 🙏

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 8, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b2c0630 
* giteaofficial/main:
  add submodule diff links (go-gitea#33097)
  [skip ci] Updated translations via Crowdin
  Update status check for all supported on.pull_request.types in Gitea (go-gitea#33117)
  Support the new exit code for `git remote` subcommands for git version >=2.30.0 (go-gitea#33129)
  Make git clone URL could use current signed-in user (go-gitea#33091)
  Filter reviews of one pull request in memory instead of database to reduce slow response because of lacking database index (go-gitea#33106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

@bohde bohde Awaiting requested review from bohde

Assignees
No one assigned
Labels
docs-update-needed The document needs to be updated synchronously lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/migrations size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Change displayed SSH_USER to logged in user
5 participants
@wxiaoguang @prologic @lunny @Zettat123 @GiteaBot