add submodule diff links #33097
Open
add submodule diff links #33097
+366
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds links to submodules in diffs, similar to the existing link when viewing a repo at a specific commit. It does this by expanding diff parsing to recognize changes to submodules, and find the specific refs that are added, deleted or changed. The templates are updated to add either a link to the submodule at a commit, or the diff between two commits in the event that the submodule is updated. A slight refactor was done to simplify calling RefURL on the submodule.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/translation
modifies/go
lunny
reviewed
Jan 4, 2025
wxiaoguang
reviewed
Jan 4, 2025
|
ps: we need this one first: Make git clone URL could use current signed-in user #33091 : it make the Git URL parsing more general ( |
|
Made some changes in 8d63859:
ps: need this one "Make git clone URL could use current signed-in user #33091" to rewrite
|
wxiaoguang
reviewed
Jan 5, 2025
Comment on lines
+45
to
+55
| func (si *SubmoduleInfo) RefID() string { | ||
| if si.NewRefID != "" { | ||
| return si.NewRefID | ||
| } | ||
| return si.PreviousRefID | ||
| } | ||
|
|
||
| // RefURL guesses and returns reference URL. | ||
| func (si *SubmoduleInfo) RefURL(repoFullName string) string { | ||
| return git.NewCommitSubModuleFile(si.SubmoduleURL, si.RefID()).RefURL(repoFullName) | ||
| } |
There was a problem hiding this comment.
I have a question here: why it should introduce RefID and use the if trick? It seems quite unclear.
And for the "deletion" case, I do not think git.NewCommitSubModuleFile(si.SubmoduleURL, si.RefID()) would work because the submodule config should have been deleted? So no way to construct a link by this approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds links to submodules in diffs, similar to the existing link when viewing a repo at a specific commit. It does this by expanding diff parsing to recognize changes to submodules, and find the specific refs that are added, deleted or changed.
The templates are updated to add either a link to the submodule at a commit, or the diff between two commits in the event that the submodule is updated.
A slight refactor was done to simplify calling
RefURLon the submodule. There was also aFIXMEcomment in the template that said this should be updated to account forsetting.AppSubURL. I tested this in an environment that uses a non defaultsetting.AppSubURL, and verified that it works.Related #25888