Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make git clone URL could use current signed-in user #33091

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make git clone URL could use current signed-in user #33091

wants to merge 4 commits into from
+268 −139

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 3, 2025 •
edited
Loading

close #33086

  • Add a special value for "SSH_USER" setting: (DOER_USERNAME)
  • Improve parseRepositoryURL and add tests (now it doesn't have hard dependency on some setting values)

Many changes are just adding "ctx" and "doer" argument to functions.

By the way, improve app.example.ini, remove all %(key)s syntax, it only makes messy and no user really cares about it.

Document: https://gitea.com/gitea/docs/pulls/138

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 3, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 3, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/migrations docs-update-needed The document needs to be updated synchronously labels Jan 3, 2025
@wxiaoguang wxiaoguang changed the title fix Make git clone URL could use current signed-in user Jan 3, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 3, 2025
Open
@wxiaoguang wxiaoguang force-pushed the fix-ssh-user branch 3 times, most recently from 4cd7d59 to 85782b3 Compare January 3, 2025 04:14
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Jan 3, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 3, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Jan 3, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 4, 2025
Open
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 4, 2025
@wxiaoguang wxiaoguang requested a review from Zettat123 January 6, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@Zettat123 Zettat123 Awaiting requested review from Zettat123

Assignees
No one assigned
Labels
docs-update-needed The document needs to be updated synchronously lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/migrations size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Change displayed SSH_USER to logged in user
3 participants
@wxiaoguang @lunny @GiteaBot